prn_stars is a function to print starsCode:#include <stdio.h> #include <string.h> char prn_stars(int s); int main(void){ int avg; scanf("%d", &avg); printf("%s",prn_stars(avg)); } char prn_stars(int i){ if (i >= 200) printf("*"); if (i > 200) printf("*"); if (i > 100) printf("*"); }
Your function doesn't return anything.
Your main function doesn't return any value, it should since it's declared with the return type int. This isn't causing the segfault however, the problem is with your printf statement and your prn_stars function. The %s in printf expects the first argument to be a null-terminated string. The argument is in fact nothing (afaik nothing = whatever happens to be in the eax-register in x86), since your prn_stars function does not return any value. Even if it did, the return type of char is wrong, since that is just a single char, and not a null-terminated string. So, either:
- turn prn_stars into a function that returns void, and skip the printf statement in main
- make prn_stars return a null-terminated string with the appropriate number of stars
Last edited by iceaway; 10-31-2011 at 12:05 PM.
