Finding maximum and minimum number in 2D array
This is my code to find the maximum and minimum number for the arrays. It works but I am wondering is there any other way to improve the code? or other way to find minimum and maximum.Code:void findMaxnMin(double x[][COLS]) { int max=x[0][0], min= x[0][0]; int i,j; for (i=0; i<ROWS; i++) for (j=0; j<COLS; j++) { if(x[i][j]> max) max= x[i][j]; if(x[i][j]<min) min= x[i][j]; } }
Well right now that function doesn't do anything, since max and min are never read. Also, x is a bad name for a variable.
It is too clear and so it is hard to see.
A dunce once searched for fire with a lighted lantern.
Had he known what fire was,
He could have cooked his rice much sooner.
Does C care that he is assigning a double to an integer variable?
If he doesn't care that he is turning it into an int, C won't either. It'll just truncate it as needed.Originally Posted by camel-man
Quzah.
Hope is the first step on the road to disappointment.
When you want more than just the min and max, say just the Nth highest or the first N lowest etc then there are better alternatives. But for just finding the min and max, there is no better algorithm to do it. Note that a better implementation would not rely on global constants and would use the corrrect the data types for min and max.
You should also actually do something with the results like pass them out by writing through pointers that are passed in.
My homepage
Advice: Take only as directed - If symptoms persist, please see your debugger
Linus Torvalds: "But it clearly is the only right way. The fact that everybody else does it some other way only means that they are wrong"
