Thread: Tic Tac Toe

So, you can's use arrays, loops and addional functions, but can you use macros? This can be compressed:

Code:

void printBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
                int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR)
{
   if ( *pTopL == 0)
      {
         printf("X");
      }
      else printf("O");
 
 
   if ( *pTopC == 0)
      {
         printf("X");
      }
      else printf("O");
 
 
   if ( *pTopR == 0)
      {
         printf("X");
      }
      else printf("O");
 
 
   if ( *pCenL == 0)
      {
         printf("X");
      }
      else printf("O");
 
 
   if ( *pCenC == 0)
      {
         printf("X");
      }
      else printf("O");
if ( *pCenR == 0)
      {
         printf("X");
      }
      else printf("O");
 
 
   if ( *pBotL == 0)
      {
         printf("X");
      }
      else printf("O");
 
 
   if ( *pBotC == 0)
      {
         printf("X");
      }
      else printf("O");
 
 
   if ( *pBotR == 0)
      {
         printf("X");
      }
      else printf("O");
 
 
   printf(" %c | %c | %c \n", *pTopL, *pTopC, *pTopR);
   printf(" %c | %c | %c \n", *pCenL, *pCenC, *pCenR);
   printf(" %c | %c | %c \n", *pBotL, *pBotC, *pBotR);
}

Into this:

Code:

#define PRINT_BOARD_HELPER(var)  if ( *var== 0)\
      {\
         printf("X");\
      }\
      else printf("O");
void printBoard(int* pTopL, int* pTopC, int* pTopR, int* pCenL,
                int* pCenC, int* pCenR, int* pBotL, int* pBotC, int* pBotR)
{
 
   PRINT_BOARD_HELPER(pTopL)
   PRINT_BOARD_HELPER(pTopC)
   PRINT_BOARD_HELPER(pTopR)
   PRINT_BOARD_HELPER(pCenL)
   PRINT_BOARD_HELPER(pCenC)
   PRINT_BOARD_HELPER(pCenR)
   PRINT_BOARD_HELPER(pBotL)
   PRINT_BOARD_HELPER(pBotC)
   PRINT_BOARD_HELPER(pBotR)

   printf(" %c | %c | %c \n", *pTopL, *pTopC, *pTopR);
   printf(" %c | %c | %c \n", *pCenL, *pCenC, *pCenR);
   printf(" %c | %c | %c \n", *pBotL, *pBotC, *pBotR);
}

Better yes?


From a broader perspective, you should avoid repeat code. The first remedy is a loop. If that's not applicable, try a function. As a last resort consider a macro.

Originally Posted by Dannibe7

So to determine a winner would I just have to do a lot of if statements?

Originally Posted by CommonTater

A LOT of if() statements.

Well there are only 8 ways to win.

Why are you using pointers on functions that never change their arguments? Also, what about empty squares? You are assuming that these boards have a full nine moves plotted?


Quzah.

Originally Posted by quzah

Why are you using pointers on functions that never change their arguments? Also, what about empty squares? You are assuming that these boards have a full nine moves plotted?


Quzah.

Yeah, it says so in his first post:
1) Generate the board randomly
2) Evaluate if it's valid
3) Find the winner

Although, I don't understand why would someone want to do such a thing...

no players or moves

Well that explains one problem. But since you have randomly generated boards, how do you know who won first?

Code:

xox
oox
xox

Also, you still don't need to be using pointers for a function that isn't trying to change any values.


Quzah.

Well be sure you account for this:

Code:

*xx
xoo
xoo

x's final valid move is * which gives him 2 wins.


Quzah.

You've just explained how.

Code:

if topL == X and topC == X and topR == X
    print yay you win X across the top row

Quzah.