Thread: C programming homework (SHUFFLING A DECK OF CARD)

hi, i have to create a program that will shuffle a deck of cards, i am just missing a function but i am still getting an error on the last part, can someone please help me? Thank you.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#define NCARDS 52
#define NPROPS 2
#define NSUITS 4
#define NFACES 13
char* suit[NSUITS]={"hearts","spades","clubs","diamonds"};
char* face[NFACES]={"ace","two","three","four","five","six","seven","eight","nine",
"ten","jack","queen","king"};
void PrintCard(int deck[NCARDS][NPROPS], int i);
void InitDeck(int deck[NCARDS][NPROPS]);
void SwapCards(int deck[NCARDS][NPROPS], int src, int dest);
void ShuffleDeck(int deck[NCARDS][NPROPS]);
int GetPlayValue(int deck[NCARDS][NPROPS], int i);


int main()
{
    int deck[NCARDS][NPROPS];
    int src;
    int dest;
    int i;
    srand(time(NULL));
    InitDeck(deck);
    ShuffleDeck(deck);
    SwapCards(deck, src, dest);
    for (i=0; i<NCARDS; i++)
    {
        PrintCard(deck,i);
    }
    GetPlayValue(deck,i);

    return 0;
}

 void InitDeck(int deck[NCARDS][NPROPS])
{
    int suit;
    int face;
    int row;
    for (suit=0; suit<4; suit++)
    for (face=0; face<13; face++)
    {
        deck[row][0]= suit;
        deck[row][1]= face;
         row++;
    }
void ShuffleDeck(int deck[NCARDS][NPROPS]);
{
    int src, dest, i;
    for (i=0; i<NCARDS; i++)
    {
        src = i;
        dest = rand()%NCARDS;
        SwapCards(deck, src, dest);

    }
}
 void SwapCards(int deck[NCARDS][NPROPS], int src, int dest);
{
    int temp;
    int src;
    int dest;
    temp = deck[src][0];
    deck[src][0] = deck[dest][0];
    deck[dest][0] = temp;
    temp = deck[src][1];
    deck[src][1] = deck[dest][1];
    deck[dest][1] = temp;

}
void PrintCard(int deck[NCARDS][NPROPS], int i);
{
    int tempsuit;
    int tempface;
    int i;
    tempsuit = deck[i][0];
    tempface = deck[i][0];
    printf("Card %d = %s of %s\n", i, suit[tempsuit], face[tempface]);
    GetPlayValue(deck,i);
}

Thank you. Could you help me with line 80?? i dont get what im doing wrong!

You have two variables with the same name: i.

One is the parameter i, and the other is the local function i.

Give them unique names.

by doing that i change the meaning of function. could u give me a example? because i thought that doing that will matter since they are being declared in 2 diff functions.

If you have two variables with the same name, one from the local function, and one from another function, the local variable will be given the address inside the function, effectively "hiding" the non-local version of the variable.

That has been my experience with it, but the official standard, I believe, says the result is undefined. In any case, it's an error in logic and clarity in the code. You will not change the meaning of the function, you still have one i variable (the parameter). That's the one you keep. Delete the other declaration of i.

when i change the variable i from that function just everything else goes crazy. some variables get undeclared i dont know

Well, that's why you ask, and I do know. < sorry, but facts is facts >

What errors are you getting? Paste 'em up here! Did you fix the errors that Salem mentioned earlier in the thread?

Maybe you better upload the code, so I can load it up and see what's doing, and be sure I'm looking at the current code version.

Originally Posted by CommonTater

Ok guys ... why is your deck of cards a 2 dimensional array? What is the second element doing for you?

I don't know why the professor wants us to use the deck of cards as a 2 dimensional array, but the assignment was to build upon the code he had given us, which was

Code:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#define NCARDS 52
#define NPROPS 2
#define NSUITS 4
#define NFACES 13

char* suit[NSUITS]= {"hearts","spades","clubs","diamonds"};
char* face[NFACES]= {"ace","two","three","four","five","six","seven","eight","nine",
                     "ten","jack","queen","king"
                    };
void PrintCard(int deck[NCARDS][NPROPS], int i);
void InitDeck(int deck[NCARDS][NPROPS]);
void SwapCards(int deck[NCARDS][NPROPS], int src, int dest);
void ShuffleDeck(int deck[NCARDS][NPROPS]);
int GetPlayValue(int deck[NCARDS][NPROPS], int i);

int main()
{
    int deck[NCARDS][NPROPS];
    int i;
    srand(time(NULL));
    InitDeck(deck);
    ShuffleDeck(deck);
    for (i=0; i<NCARDS; i++)
    {
        PrintCard(deck,i);
    }
    return 0;
}

You may want to ask him or her ...

You can compensate by modifying my code snips, but I really don't see much point in it...