Can't figure out this doesn't work: While e or E is not pressed

[superbbrr]

I have a menu displayed, if the user presses H or h, it does something.

If the user presses S or s, it does something else.

If the user presses E or e, the program exits.

This works: while ((ch = getch()) != 'e')

but not the following:

    while ((ch = getch()) != 'e' || (ch = getch()) != 'E' )
    {
        if (ch == 'H' || ch == 'h' ) {
            printf("asdf\n");
        }
        else if (ch == 'S' || ch == 's' ) {
                printf("erwer\n");
        }
        else {    
            printf("Will display status by default\n");
        }

    }

The terminal just seems to lock up.

[quzah]

while ((ch = getch()) != 'e' || (ch = getch()) != 'E' )

Each one of those reads a different key. Which actually fixes one problem you would be having, but ruins all the rest of it.

When you type E to exit, you also hit enter. First, ch gets assigned E, then it gets assigned ENTER with the second call to getch. You should be doing something like:

while( (c = getch()) != 'e' && c != 'E' )
{
    ...
}

Now you could just use the toupper or tolower functions as well, and just check once, but it all works out the same in the end. However, after you do any of what I've described, you still need to take care of that ENTER key you've just typed.


Quzah.

[anduril462]

You call getch() twice. The first time it grabs what you enter, the second time it's probably waiting for another key press (note, getch is non-standard, so I don't really know what it does). Also, you probably want an && in your while loopTry:

while ((ch = getch()) != 'e' && ch != 'E') {
    ...
}

[Salem]

Or even
ch = tolower(getch())
if you don't care about case at all later on, and it would simplify all the later conditions.