Thread: If clause based on a string

Hi, I'm trying (for a bit of fun with a friend of mine) to write a program which will poke fun at his team. The problem is I can't get the program to run with an if condition based on a char. I've tried it with a constant and a variable, and whilst in both cases it operates with an int/float it won't with a string (char array).

Code:

/*Calcio.c Program to read football team and issue a message
*/


#include<stdio.h>


int main()


char team[80];
char squadra[7] = "Inter";


{
printf("Che squadra tifi?:");
scanf("%s",&team);


if ( team == squadra )
{
printf("Forza Inter, sei un tifoso fantastico.");
}


else
{
printf(" %s SERIE B SERIE B SERIE B!!!!!!!!!!!!!" ,team);
}
return 0;
}

This is probably because its something I haven't covered on my course yet so I'm probably out-of-my-depth.

(Sorry that some of it is in Italian, he's a Juve fan and I'm an Interista hence the Italian).

Whilst its just a bit of fun at this stage I think it'll help for me to know with a view to later stages of my studies.

You can not use the comparison operator== with C-strings, you need to use the strcmp() function from string.h.

Jim

Originally Posted by jimblumberg

You can not use the comparison operator== with C-strings, you need to use the strcmp() function from string.h.

Jim

Thanks!

Only problem I have now is it will only print the first one (i.e. Forza Inter.......)

How to I get it to react to a wrong answer and print a different message (i.e. Juve SERIE B.....)

I tried using two while conditions but it doesn't seem to work.

You should rarely use the assignment operator= with char pointers either. You should use the strcpy() function instead.

Jim

Originally Posted by Rodaxoleaux

Also, why do people keep using assignments with char[] arrays instead of char* pointers. In my usage, char[] has caused me nothing but trouble.

Maybe an area of C you should work on . They're actually called initializers, not assignments (they must be part of the variable definition). You can't assign to an array with = in C. As for char *, they aren't all that helpful if you want to change the contents. String constants should be just that, constant. Most modern implementations store them in an unwritable segment of memory. On many systems, the following would seg fault:

Code:

char *victim_name = "Jon Doe";  // points to a string constant, probably stored somewhere in unwritable memory
if (victim_identified)
    strcpy(victim_name, "Fred Flintstone");  // oops, can't copy into unwritable memory, seg fault

whereas the following would work

Code:

char victim_name[MAX_NAME] = "Jon Doe";
if (victim_identified)
    strcpy(victim_name, "Fred Flintstone");

Sure, there are ways around the char * issues, like pointing victim_name to a char array or malloc'ing some memory for it, but that doesn't always make them the best solution.

Code:

/*Calcio.c Program to read football team and issue a message
*/


#include <stdio.h>
#include <string.h>


int main ()
{
  char squadra[7] = "Inter";
  char team[80];
  
  do {
  
     printf ("Quale squadra tifi? ");
     gets (team);
  
  } 


while (strcmp(team, squadra) == 0)


{printf ("Forza Inter, sei un tifoso bellissimo!!!"};


or
  
printf ("Serie B!");






  return 0;
}

Sorry for being a dope but this is what I'm left with and I'm totally confused.

I just want to play a joke where it asks what team you support, I input Inter and it puts out a positive message. Whereas, when he puts in Juve it puts out a negative one.

Maybe its beyond me at this stage.

You should be using an if/else statement not a loop.

Code:

if(strcmp(team, squadra) == 0)
{
   printf ("Forza Inter, sei un tifoso bellissimo!!!"
}
else
{
   printf ("Serie B!");
}

You may want to study this link: Control structures

Jim

Originally Posted by jimblumberg

You should be using an if/else statement not a loop.

Code:

if(strcmp(team, squadra) == 0)
{
   printf ("Forza Inter, sei un tifoso bellissimo!!!"
}
else
{
   printf ("Serie B!");
}

You may want to study this link: Control structures

Jim

Thanks!!!! Worked perfectly and joke performed well!