Thread: error problems

hey guys so this file is a separate file from the main program i am writing and i keep getting a "lvalue required as left operand of assignment"
i still cant figure out what to do after fiddling around with the error.
this function is suppose to take 2 input values from my main program and see which of the pair of numbers is bigger(max) and smaller(min)
also could i ask how do i make a file.h and how do i write functions in a ".h" file
appreciate the help i can get

Code:

float max(float input)
{
float input1, input2;
if (input1 > input2)
{
max = input1;
}
else
{
max = input2;
}
}


float min(float input)
{
float input1, input2;
if (input1 < input2)
{
min = input1;
}
else 
{
max = input2;
} 
}

omg i cant believe i missed that thanks i will try it now

Originally Posted by Salem

Well you're using the name of the function as the return result.

Say something like
result = max;

Then at the end of the function
return result;

This is your one and only freebie... Study how this works until you understand it...

Code:

float max(float input1, float input2)
  {
    return (input1 > input2) ? input1 : input2; 
  }


float min(float input1, float input2)
  {
    return (input1 < input2) ? input1 : input2;
  }

See how easy it is?

so i made the corrections:

Code:

float max(float input)
{
float input1, input2, ma1,mi2;
if (input1 > input2)
{
ma1 = input1;
}
else
{
mi2 = input2;
}
}


float min(float input)
{
float input1, input2, ma1, mi2;
if (input1 < input2)
{
mi2 = input1;
}
else 
{
ma1 = input2;
} 
}

i have another program which the user inputs 2 variables. it seems that the variables arent being passed to the max and min functions am i declaring the functions right in this main function?

Code:

#include <stdio.h>
#include <stdlib.h>

float max(float input);
float min(float input);

main()
{
float input1, input2;
int term;
    while (term != EOF)
{
float i1, i2;
printf("Enter a pair of float values:\n");
term = scanf("%f" "%f", &input1, &input2);
printf("You have entered %f and %f\n", input1, input2);
max(i1);
min(i2);
printf("Max = %f and Min = %f\n", i1, i2);
}
    if (term == EOF)
{    
printf("control-D"); 
exit(0);    
}
}

hey CommonTater so i did the changes in the program and ran it without problems. The functions are either not doing their intended tasks or the stuff in main isnt working either one i keep getting the same results.

Originally Posted by CommonTater

As salem points out...
You are only passing in a single value.
Your internal compare is on essentially random numbers, using uninitialized variables.
Your functions aren't returning anything.
You call the function from main but ignore it's return value...

I'm amazed it even compiles.

Try this...

Code:

float max(float input1, float input2)
  { 
    if (input1 > input2)
       return input1;
    else
       return input2;
   }

See how it works... two values in the top, a decision based on those values... one value returned at the bottom.

Now in your main code you need...

Code:

nMax = max(input1,input2);

nMax is assigned the value returned by the function.

The answer comes out the bottom... not the top.

corrections:
1st program main function:

Code:

#include <stdio.h>
#include <stdlib.h>

float max(float input, float inputt);
float min(float input, float inputt);

main()
{
float input1, input2;
int term;
    while (term != EOF)
{
float nMax, nMin;
printf("Enter a pair of float values:\n");
term = scanf("%f" "%f", &input1, &input2);
printf("You have entered %f and %f\n", input1, input2);
nMax = max(input1,input2);
nMin = min(input1,input2);
printf("Max = %f and Min = %f\n", nMax, nMin);
}
    if (term == EOF)
{    
printf("control-D"); 
exit(0);    
}
}

2nd program being called by 1st:

Code:

float max(float input1, float input2)
  { 
    if (input1 > input2)
       return input1;
    else
       return input2;
   }


float min(float input1, float input2)
  { 
    if (input1 < input2)
       return input1;
    else
       return input2;
   }

It can't be compiling... Line 15 should cause an error about incorrect types...

Code:

term = scanf("%f" "%f", &input1, &input2);

Should be...

Code:

term = scanf("%f %f",&input1, &input2);

Most likely the compile is failing but it's running a previous version of the program... so it SEEMS to be giving you the same results. Set your compiler warnings to maximum and treat each message as a problem to be corrected.