Thread: Intiger to float

I hava an programm, and it runs perfect, exept above input of 33000 it doesnt work anymore. This is because my input is an int so the solution is to make it an float, but when i do this the programm doesn't do what i want

note: input = nInvoer

Code:

/* INCLUDES: */#include  <stdio.h>
#include <stdlib.h>
#include <conio.h>
#include <string.h>
#include <math.h>






/* MAIN PROGRAM: */


int main(void)
{
   int nInvoer;
   int nIndex;
   int i;
   int nGetalgevonden;
   char chE12[12] = {10,12,15,18,22,27,33,39,47,56,68,82};
   char chAgain = 'y';
   while(chAgain=='y')
	{
     	nGetalgevonden=2;
      printf("Voer een getal in\n") ;
      scanf("%d", &nInvoer);


      if (nInvoer <100)
      {
      	for( nIndex =0; nIndex<12; nIndex++)
   		{
      		if (nInvoer == chE12[nIndex])
         	{
       			nGetalgevonden=1;
         	}
      	}
       }
      else
      {
      	for (i=0; i<5; i++)
      	{
        	nInvoer=nInvoer/10;
        	for( nIndex =0; nIndex<12; nIndex++)
      			{
       				if (nInvoer == chE12[nIndex])
       				{
       					nGetalgevonden=1;
         			}
            	}
       }
      }


       if (nGetalgevonden==1)
       {
        printf("getal zit in de e12 reeks\n");
       }
       else
       {
        printf("getal zit niet in de e12 reeks\n");
       }






      printf("Do you want to run this program again? [y/n]:\n ");
      chAgain = getche();


		}


      return(0);


   }

Well, first of all, if you're hitting the wall at 33000 you're probably working on a compiler with 16 bit integers and the best fix for that problem is to get a newer compiler with 32 bit integers... In cases like this I generally recommend Pelles C (Yes, I'm a link, click me!) which writes both 32 and 64 bit executables (depending on your OS) and is right up to date ... and free.

Making your value into a float is going to mess you up pretty good since you are comparing with integers. Floats don't always land on exactly whole numbers so the "last bit ambiguity" problem will mess your comparisons up pretty good.

You might try using a float but typecasting to int during comparisons...

Code:

float x;
int list[100];

if ((int)x == list[y])
...

I'm not 100% shure that will solve the problem, but it's worth a try...


But you will have to forgive my curiosity... why on Earth would any credible educator insist upon using an ancient compiler when there are far better and more up to date ones available for free?

What about using a long int instead of an int?

Aight, i found the problem. You can safely make int nInvoer to float nInvoer. The only thing to do is to change the scanf("%d"... into scanf("%f"... Thanx for the help:P

Originally Posted by PvtVampire

my teacher: i have no idea why we have to use an prehistoric compiler.

Does he?