i want it to say "steven is cool" if i type in steven
Code:#include <stdio.h> int main (int argc, const char * argv[]) { char steven; char bob[10]; printf("\nname:"); gets (bob); if (bob == steven) { // i get it right here printf("steven is cool"); } return 0; }
bob is an array of 10 characters
steven is a single character
You can't compare a single character to a whole bunch of characters. They are different types of things. For starters, steven needs to be an array also. Next, assuming you want an actual string, you need to set it to contain something (for example, the string "steven"). Then you need to compare those strings with strcmp (assuming you don't want to loop through them both one letter at a time and compare them that way).
Also, you should use something other than gets to read your input.
Cprogramming.com FAQ > Why gets() is bad / Buffer Overflows
Cprogramming.com FAQ > Get a line of text from the user/keyboard (C)
Quzah.
Hope is the first step on the road to disappointment.
You have one variable named steven which is empty, and a pointer that you try to compare (a char is an 8 bit integer). You can not compare strings with == in C, use something like strcmp().
Code:char *steven = "steven"; if( strcmp(bob, steven) == 0 ) { // they are equal }
thank you for your help
That should be:
Code:const char *steven = "steven";
It is too clear and so it is hard to see.
A dunce once searched for fire with a lighted lantern.
Had he known what fire was,
He could have cooked his rice much sooner.
sure
Code:#include <stdio.h> int main (int argc, const char * argv[]) { char *david = "david"; char *steven = "steven" ; char *daniel = "daniel"; char bob[10]; printf("\nname:"); gets (bob); if ( strcmp(bob, steven) == 0) { printf("steven is cool"); { if ( strcmp(bob, david) == 0) { printf("david is not"); { if ( strcmp(bob, daniel) == 0) { printf("daniel mabye"); } return 0; } /....i get 4 expected declaration or statement at end of input
What do you need help with? You should declare *david and company with const char as suggested by King Mir. Those are string literals and should not be modified. Also don't use gets.
BTW, you need to include string.h to use strcmp() should have mentioned that I guess.
Code:Some of your '{' should be '}'.
It is too clear and so it is hard to see.
A dunce once searched for fire with a lighted lantern.
Had he known what fire was,
He could have cooked his rice much sooner.
I just started programming a week ago I'm really I'm glad I found this website and thank you for you help......instead of the ending the program how would I get back to gets I don't care for loops I just wanna try and instead of gets what should I use for this program
Code:#include <stdio.h> int main (int argc, const char * argv[]) { const char *david = "david",*steven = "steven", *daniel = "daniel"; char bob[10]; printf("\nname:"); gets (bob); if ( strcmp(bob, steven) == 0) { printf("steven is cool"); } if ( strcmp(bob, david) == 0) { printf("david is not"); } if ( strcmp(bob, daniel) == 0) { printf("daniel mabye"); } return 0; }
fgets() but quzah provided a link that explained that. What you would do to replace gets in your code with fgets:
The middle argument will prevent bob from over flowing, the last argument is a file pointer, in this case stdin but you can also use fgets with files.Code:fgets(bob, 10, stdin);
Last edited by Subsonics; 10-03-2011 at 07:50 PM.
Instead of gets use fgets:
And to repeat things multiple times, use a loop. That's what they're for. You're not qualified to decide what parts of the language you should and shouldn't use.Code:fgets (bob, sizeof(bob), stdio);
It is too clear and so it is hard to see.
A dunce once searched for fire with a lighted lantern.
Had he known what fire was,
He could have cooked his rice much sooner.
You could replace this:Originally Posted by steevethebeeve1
with:Code:char bob[10]; printf("\nname:"); gets (bob);
Where the "..." could say, print an error message then end the program or something like that. Note that I used sizeof(bob) here because bob is an array of 10 characters; if you move this snippet to a function for which bob is a pointer instead, then you should replace sizeof(bob) with the variable holding the size of the array.Code:char bob[10]; printf("\nname:"); if (fgets(bob, sizeof(bob), stdin)) { /* If the newline was read, discard it */ char *p = strchr(bob, '\n'); if (p) { *p = '\0'; } } else { /* Deal with the input error */ /* ... */ }
Look up a C++ Reference and learn How To Ask Questions The Smart Way
Shorter with the same safety should be:
Code:char bob[10]; scanf("%9[^\n]",bob);while(getchar()!='\n');
Not even close...
