Thread: Coding help.... have a few questions

I am having a lot of trouble with this program, I've tried adding and changing things but I think I'm making it worst.
My 1st problem is the program seems to end after imputing the 1st values.... It didn't do that before... I need it to take in values and out put which values are negative, odd, and zero. However I can't do that if the program ends after the users 1st input... I'm guessing its an ; or bracket problem that I couldn't find

Code:

#include <stdio.h>
#include <stdlib.h>

/* Homework Create a program that accepts user input and store a set of integers in one for loop,
 a set of double values in a second for loop and a set of characters in a character string.
 Then the program will count the number of positive, zero and negative values for the integer 
and double arrays and the number of upper and lower case variables in the character string. 

In other words it needs to:
The program is just to count the number of positive, negative and zero
values that a user enters. In the first case, the user enters integers
and then real values are entered. A character string is then entered
and the program counts upper and lower case characters.*/

#include <stdio.h>
#include <stdlib.h>

int main()
{

    int intarray[10];
    double doublearray[10];
    char string[20];
    int uppercount = 0, lowercount = 0;
    int i;
    int numints, numdoubles;
    int negcount, poscount, zerocount;

    printf("Input number of integer values: ");
    scanf("%d", &numints);
    for (i=0; i< numints; i++)
    {
        printf("Enter an integer value: ");
        scanf("%d", &intarry[i]);
    }
    /* Then ask for number of double values and read them in using %lf */
    printf("Input a another value:  ");
    scanf("%lf", &numdoubles);
    for (i=0; i< numdoubles; i++)

    {
        printf("Enter an integer value: ");
        scanf("%lf", &doublearray[i]);
    }

    /* #3 */
    printf("Enter a short character string: ");
    scanf("%s", string);
    negcount=0;/* initialize the counters*/
    poscount=0;
    zerocount=0;
    for (i = 0; i < numints; i++)
    {
        if (intarray[i] < 0)
            negcount++;
        printf("You entered %d negtive values ",negcount);

        if (intarray[i] == 0)
            zerocount++;
        printf("You entered %d zero values ",zerocount);

        if (intarray[i] > 0)
            poscount++;
        printf("You entered %d postive values",poscount);
    }

   /* print out counter values */
   printf("Enter a short character string: ");
    scanf("%s", string);
    negcount=0;/* initialize the counters*/
    poscount=0;
    zerocount=0;
    /* Do counts for double array */
    for (i = 0; string[i]; i++)
    {
        if ((string[i] >= 'A') && (string[i] <= 'Z'))
            uppercount++;
            printf("You have %d upper case characters\n",uppercount);

        if ((string[i] >= 'a') && (string[i] <= 'z'))
            lowercount++;
            printf("You have %d lower case characters\n",lowercount);
    }
   /* print out counter values etc.....*/

    system("Pause");
    return 0;
}

thanks for any help!!!

That code does not compile because of a typo on line 31. You need to post the code you are actually using that created the problem you describe.

Well the first thing is get a compiler that can warn you about printf/scanf mis-use.

Code:

$ gcc -W -Wall -ansi -pedantic bar.c 
bar.c: In function ‘main’:
bar.c:38: warning: format ‘%lf’ expects type ‘double *’, but argument 2 has type ‘int *’

Then there is this

Code:

        if ((string[i] >= 'A') && (string[i] <= 'Z'))
            uppercount++;
            printf("You have %d upper case characters\n",uppercount);

Despite your indentation, what you really have is this.

Code:

        if ((string[i] >= 'A') && (string[i] <= 'Z')) {
            uppercount++;
        }
        printf("You have %d upper case characters\n",uppercount);

This mistake can easily be avoided by always using braces, even when they seem to be optional.
The problem being, there is no error message going from optional to compulsory, the code just doesn't work as expected.


Perhaps you only want to print the results ONCE at the end, in which case,

Code:

    for (i = 0; string[i]; i++)
    {
        if ((string[i] >= 'A') && (string[i] <= 'Z'))
            uppercount++;
        if ((string[i] >= 'a') && (string[i] <= 'z'))
            lowercount++;
    }
    printf("You have %d upper case characters\n",uppercount);
    printf("You have %d lower case characters\n",lowercount);

this is what my code looks like now

That is the third time you have made that claim and still posted code that contains the error I mentioned in post #2:

Code:

#include <stdio.h>
#include <stdlib.h>
 
int main()
{
 
    int intarray[10];
    double doublearray[10];
    char string[20];
    int uppercount = 0, lowercount = 0;
    int i;
    int numints, numdoubles;
    int negcount, poscount, zerocount;
 
    printf("Input number of integer values: ");
    scanf("%d", &numints);
    for (i=0; i< numints; i++)
    {
        printf("Enter an integer value: ");
        scanf("%d", &intarry[i]);

No compiler in the world can possibly overlook that error (altho apparently Salem kindly did, corrected it so it would compile, and posted the subsequent errors).

But since that code cannot be compiled, how am I to know it does not also contain other errors or differences that are not in your REAL source? And if you cannot provide source that does what you say it does, how can anyone help you with a problem in it?

> I'm using codeblocks.... its the program that was suggested by the professor....
It's a good choice.
Just so you know, the default compiler is GCC, so you should be able to add those -W flags to your project->settings->compiler kind of dialog.

Do you type in anything to respond to "Input number of integer values:"
Note, if it is expecting an int, and you type in a letter, then this is bad.

Originally Posted by Salem

>
Just so you know, the default compiler is GCC, so you should be able to add those -W flags to your project->settings->compiler kind of dialog.

Huh!?!?! Ok does that mean code bock has GCC as the compiler.... add what? what flags?

um ok I downloaded it for free..... I didn't have it shipped.....I am guessing that means something else, will this help me learn how to fix errors with my program...??

um I did... I still not seeing flags in the help menu...... I see about tips and plugins.... under plugins there is a long list... I looked under debug.. because I think that's what I want to do... and I'm still confused... so I replied....and now i've looked under half of them..... and now I get where he said the compiler is

This plugin is an interface to various compilers:

GNU GCC compiler
Microsoft Visual C++ Free Toolkit 2003
Borland C++ Compiler 5.5

ya but I have no clue what that means... or where the flags are.... I just want to learn how to debug so I can stop bugging you people and start to solve my errors and be able to make programs... and quit being frustrated newbie.... blah I really wish this wasn't so foran to me.

Ok didn't know that but it makes sense.. thanks....