hi guys
so i developed this piece of code to help me find a co prime of a number.
basically it just a fancy way of finding a number between 1 and itself, that is a prime number and not a factor of that number
here is the code
any help is appreciated
thanks in advance =)Code:int finde(int phi){ int e =4; int resultprime; resultprime = IsPrime(e); while(e<phi){ resultprime=IsPrime(e); if(resultprime==1){ if((e%phi)!=0){ return e; break; } e++; } } }
I believe people argue that 1 isn't actually a prime, so you should be stopping at 2 really. We can't actually see IsPrime here, so who knows what it is doing. You don't need a break there, since you have just returned right in front of that. You only change e if resultprime is 1. Terrible indentation habits will get you every time.
Quzah.
Hope is the first step on the road to disappointment.
Hi Quzah
Thanks for the help
Basically the IsPrime Function returns a 1 if its a prime and a zero if it is not ?
Hope that helps you help me =)
thanks
I already helped you. Here, this is what it looks like with quality indentation:Code:int finde(int phi){ int e =4; int resultprime; resultprime = IsPrime(e); while(e<phi) { resultprime=IsPrime(e); if(resultprime==1) { if((e%phi)!=0) { return e; break; } e++; } } }
Quzah.
Hope is the first step on the road to disappointment.
As quzah just said, you only increment e if e is prime. Since e starts at 4, which is not prime; you never increment e. Hence you have your infinite loop.
Originally Posted by anduril462
Warning: Some or all of my posted code may be non-standard and as such should not be used and in no case looked at.
Ok so how does one go about fixing this, i'm completely at loss on what to do
What part of these answers are confusing:
Quzah.
Hope is the first step on the road to disappointment.
