Thread: Program closes when buffer is over limit fgets

Don't ask vaporous questions about situations we can't possibly know the first thing about...

Post your code!
Ask a specific question.

Originally Posted by NativeCodeX

Here is the code:

Code:

printf("Enter Name -> ");
char *buffer=(char *)malloc(INPUT_BUFFER);
	memset(buffer,'\0',sizeof(buffer));
	fgets(buffer,INPUT_BUFFER,stdin);
	if(buffer[strlen(buffer)-1]=='\n'){
		buffer[strlen(buffer)-1]='\0';
	}
	getchar();
//The getchar only pauses the program when the characters entered into the console are less than the buffer

Of course getchar() only pauses when the buffer is less than full. When the buffer is filled fgets() returns with stuff still in the input buffer and getchar() will read the next character in the chain and carry on like it should.

Two suggestions...
Make a bigger buffer ... 20 bytes is ludicrously small... try using the BUFSIZ constant, which I believe is 512 on most systems.
Clear the input buffer the instant fgets() returns... while(getchar() != \n); .... should do the job.

Originally Posted by AndrewHunter

Nice job, you just made all the comments the posters made completely pointless. DO NOT EDIT OUT YOUR ORIGINAL QUESTION. It invalidates the work people here did to help you and prevents the community from learning from your mistakes. This is an all volunteer service here and thus the whole point is for people to learn from eachother. By removing the original question, you are preventing that from happening.

Way to help out the community. I for one will make sure I never help you now.

Probably didn't want his teacher to see that he got help with his homework...

I wonder if our friend Webmaster could make it so people can't edit message 1, in a thread?

Or maybe he could set it up so that people with fewer than a dozen or so messages have no editing priveledge at all.

Originally Posted by CommonTater

I wonder if our friend Webmaster could make it so people can't edit message 1, in a thread?

Or maybe he could set it up so that people with fewer than a dozen or so messages have no editing priveledge at all.

The later is a nice idea.
I'd suggest another idea. No Editing for anyone, just append ! (Most of us append anyway...instead of editing.)

Originally Posted by manasij7479

The later is a nice idea.
I'd suggest another idea. No Editing for anyone, just append ! (Most of us append anyway...instead of editing.)

And how do we deal with things like bad formatting in code tags, magic smilies, spelling errors and typos...

If I had a vote on this, I'd say "No editing for the first 25 messages"... A member should know the board rules by then.

And how do we deal with things like bad formatting in code tags, magic smilies, spelling errors and typos...

Oh..forgot about those..

Originally Posted by manasij7479

Oh..forgot about those..

And I'm betting we all wish we could