Thread: String table and printing english equivalent

I have a question that is still boggling my mind. Since my lecturer never gives me the answer. So, I decided to ask the board about this. Sorry if the post is a bit messy. Im quite new. The question goes like this.


"Write a C program that creates a string table containing the English words for the digits 0 through 9. Using this table, allow the user to enter a digit and then have your program display the word equivalent. The program has to allow the user to enter again the digit if he enters something other than digits 0 through 9."

I have created a code. I don't know if I answered the question. Can anyone rectify me if I didn't?

Code:

#include <stdio.h>

void num_to_english(char* zero, char* one, char* two, char* three, char* four, 
                    char* five,char* six, char* seven, char* eight, char* nine);

void main()
{
     char a,b,c,d,e,f,g,h,j,k;
     num_to_english(&a,&b,&c,&d,&e,&f,&g,&h,&j,&k);
     getchar();
}

void num_to_english(char* zero,char* one, char* two, char* three, char* four, 
                    char* five, char* six, char* seven, char* eight, char* nine)
{    
    int number,i;
    zero = "zero"; one = "one"; two = "two"; three = "three"; four = " four";
    five = "five"; six = "six"; seven = "seven"; eight = "eight"; nine = "nine";
    printf("Please insert a number from 0-9 : ");
    scanf("%d", &number);
    printf("The %d equivalent in english is : ",number);
    if(number>=0&&number<=9)
     {switch(number)
        {case 0:
         printf("%s", zero);
         break;
         case 1:
         printf("%s", one);
         break;
         case 2:
         printf("%s", two);
         break;
         case 3:
         printf("%s", three);
         break;
         case 4:
         printf("%s", four);
         break;
         case 5:
         printf("%s", five);
         break;
         case 6:
         printf("%s", six);
         break;
         case 7:
         printf("%s", seven);
         break;
         case 8:
         printf("%s", eight);
         break;
         default:
         printf("%s", nine);}}
    else
         {printf("is out of range. Please re-enter.\n\n");
         main();}
}

Thank you so much!!

Originally Posted by jimmyskabez

I have a question that is still boggling my mind. Since my lecturer never gives me the answer. So, I decided to ask the board about this. Sorry if the post is a bit messy. Im quite new. The question goes like this.

"Write a C program that creates a string table containing the English words for the digits 0 through 9. Using this table, allow the user to enter a digit and then have your program display the word equivalent. The program has to allow the user to enter again the digit if he enters something other than digits 0 through 9."

I have created a code. I don't know if I answered the question. Can anyone rectify me if I didn't?

In deference to my esteemed colleques... your code may give you the right display, but it's not very good at the job...

1) The correct form of main() in this case is int main (void) and it returns an integer error value to the OS on exit (usually 0).

2) Never, ever, call main() recursively .. and especially not from within a function!

3) Moving 90% of your code out of main() does not a good function make. Functions should do one task. In your case, the best function would take the integer value of your user's input (which should be in main()) and print out the word corresponding to the number.

4) Passing values into a function is NOT how you create variables for use inside a function. Parameters to functions should carry needed data into a function and you should never create more parameters than you need... in your case, following #3, one parameter would suffice...

5) There is no need --or reason-- to assign 10 strings when you could just as easily use printf() to print the actual word in your switch/case statement.

Aside from this, there is a far more efficient way of doing this... Have you covered arrays in your course yet? An experienced programmer could probably do this in 20 lines or less...

Thanks so much guys for the replies. I'm still going through the tutorials to re-edit my codes. Still a new programmer. And yes, my compiler accepts void main(), that's why I use it. Some of my lecturers even use it. But, now I know its wrong so I'll change it. Thanks! Still editing. If I come up with another solution. Which may take time, I'll post it back here later.

He needs the string table, however:

Code:

Write a C program that creates a string table containing the English words for
the digits 0 through 9. Using this table, allow the user to enter a digit and then have 
your program display the word equivalent.

table == array ?

I did an editing to my codes. But, still. I don't think I answered the string table question. It answers all the other parts. Just the part using string table. I just don't know how.

Code:

#include <stdio.h>

int print_english_word(int num);

int main()
{
    int num;
    do
    {
        printf("Please insert a number: ");
        scanf("%d", &num);
        if(num>=0&&num<=9){
        printf("\n%d is ", num);
        print_english_word(num);
        getchar();
        getchar();
        return 0;}
        else
        printf("is out of range!!\n");
        getchar();
    }
    while (!print_english_word(num));
    return 0;
}


int print_english_word(int num)
{
        switch(num)
        {case 0:
         printf("zero");
         break;
         case 1:
         printf("one");
         break;
         case 2:
         printf("two");
         break;
         case 3:
         printf("three");
         break;
         case 4:
         printf("four");
         break;
         case 5:
         printf("five");
         break;
         case 6:
         printf("six");
         break;
         case 7:
         printf("seven");
         break;
         case 8:
         printf("eight");
         break;
         case 9:
         printf("nine");
         default:
         printf("Try again\n");}
    return 0;
}

Sorry about the lots of getchar's. The output just won't pause. I dont want to burden with system pause so I put getchars. Hope to get replies soon.

Yes.