Reading from config file and attempting to use strtok() to end of line

[chevyman2002]

Basically, here's the function in question:

static void ConfPassSwhois(aClient *aptr) {
	char *myport = NULL, *mypass, *mywhois = NULL;
	ConfigItem_except *e;
	char line[512];
	int len = 0;
	for (e = portpass; e; e = (ConfigItem_except *) e->next) {
		strcpy(line,e->mask);
		myport = strtok(line, ":");
		if (myport) {
			mypass = strtok(NULL, ":");
			mywhois = strtok(NULL, ":");
			len = strlen(mywhois);
			if ((atoi(myport) == aptr->listener->port)) {
				if (mywhois && len < 35)
					strcpy(swhois, mywhois);
				else
					strcpy(swhois, "SWHOIS info is too long!!");
			}
		}
	}
}

The variable swhois has been previously defined in the program as 'static char *swhois[50]; '.

The line in question is "mywhois = strtok(NULL, ":");" as it's reading in 18 characters from the file properly but doesn't continue reading to the end of the line. It is intended to load something like this example '80:somepassword:some description with spaces' from the file and assign it to variables. Everything works (with numerous warnings) except that at the end of it all, 'myswhois' only contains 18 (of say 30) characters. Is there a way i can make strtok() read in more characters? If not, what should I use instead to read the line in?

Thanks for any [positive] feedback.

[Salem]

> The variable swhois has been previously defined in the program as 'static char *swhois[50]; '.
But this is an array of pointers to char, so minimally, the syntax would be

strcpy(swhois[someindex], mywhois);

But it is just an array of pointers at present. You also need to allocate memory for each pointer as well.

swhois[someindex] = malloc( strlen(mywhois) + 1 );
strcpy(swhois[someindex], mywhois);

[chevyman2002]

Thanks for your response. If i changed it from an array to just static char *swhois; Would that make any difference? Also, the line variable 'mywhois' only contains 19 characters (instead of 18 in the original post, sorry) when reading in via strtok(). What insight could you share on that? It is, so far, copying to 'swhois' perfectly fine.

[tabstop]

Currently you have 50 fingers, pointing to nothingness (that is, you have pointers but nothing for them to point to). If you change it to just a static char*, then you still don't have any memory, but just one finger pointing to nothingness. If you believe you are supposed to have a static buffer of memory, then you want

static char swhois[50];

[AndrewHunter]

Thanks for your response. If i changed it from an array to just static char *swhois; Would that make any difference? It is, so far, copying to 'swhois' perfectly fine.

However it is not copying to swhois fine. char* swhois is just a pointer. You need to actually allocate space to hold anything in it, as Salem already said. What you are seeing is undefined behavior. The easiest way to do this is just make swhois a char array, e.g. char swhois[50];

You need to revisit strtok(). Read this. I would suggest you make a simple program and get the strtok part working first, then include it into your actual program.

[chevyman2002]

I appreciate everyone's input on this matter, it has helped out greatly. Evidentally, there was another function that broke the buffer up and allocated memory into seperate variables before the function I wrote is called. It wasn't copying the entire buffer to the array in the other function and that's why I was missing information.. Again, thanks to everyone who responded, I appreciate your time.