Your code already stores input as an array of char. Every char is an integral value, so each char value can be stored in an int.
Your code already stores input as an array of char. Every char is an integral value, so each char value can be stored in an int.
This is my new code but there are still bugs in it. Could you please tell me what's wrong with it.
Code:# include<stdio.h> #include <string.h> char x[32]; char y[32]; char z[32]; char b[32]; int c[32]; int a,s; char sum[32]; int carry; main() { printf("Please input the first binary number.\n"); scanf("%s", x); printf("Please input the second binary number.\n"); scanf("%s", y); for(a=31;a>=0;a--){ if (x[a]=='0') b[a]=0; else if (x[a]=='1') b[a]=1;} for(a=31,s=0;a>=0;a--,s++){ if (y[a]=='0') c[a]=0; else if (y[a]=='1') c[a]=1;} carry=0; for(a=31;a>=0;a--){ sum[a]=b[a]+c[a]+carry; if (sum[a]>1){ sum[a]=sum[a]-2; carry=1;} else{ carry=0;} } for(a=0;a<=31;a++) printf("%d", sum[a]); }
That's your job. Why don't you tell us what part doesn't seem to work right?Originally Posted by renz15
Why are all of those global when you only have one function anyway?Code:char x[32]; char y[32]; char z[32]; char b[32]; int c[32]; int a,s; char sum[32]; int carry;Use:Code:main()Then return 0; at the end of main.Code:int main( void )What happens if I enter 8 digits instead of 32?Code:{ printf("Please input the first binary number.\n"); scanf("%s", x); printf("Please input the second binary number.\n"); scanf("%s", y); for(a=31;a>=0;a--){
What happens if both of the end digits are 1? ... and you have a carry?
Quzah.
Hope is the first step on the road to disappointment.
Just subtract '0' from each index location...
Now it's all numerically 1s and 0s...Code:for (int x = 0; x <32; x++) array[x] -= '0';
there are zeroes after the answer and when the first digits of the binary numbers is 1, the carry wont show.
There are zeros because you are telling it you area always reading 32 bits, and you only read four.
So what is your actual question? What does your program do or not do that it shouldn't or should? Why is it you think it doesn't work?
Quzah.
Hope is the first step on the road to disappointment.
If only there were some way to determine the end of a string so you don't have to cycle through every index of each array ...
And some suggestions:
- Fix the indentation/layout of your code so it's easier to read
- Make your variable names meaningful so the code is easier to read
- You drag the variable 's' around and manipulate it, but never use it for anything
- Heed Quzah's advice about the proper form of "main()"
Speaking of strings... If they do enter 32 1s/0s, they won't have enough room for the nul terminator, which means it will get written past the end of the array (that's bad, just in case the OP doesn't know).
Quzah.
Hope is the first step on the road to disappointment.
Yes, I actually noticed that just now while writing my own version of this program.
I wonder if the OP has considered making a loop that would cycle through the character array and count until it reached a certain (special) character. Perhaps they could use this count for something helpful.
Can you tell the code for that 'cause I really don't know. Please.
Never a time like the present to learn. C-Style Strings tutorial
Warning: Some or all of my posted code may be non-standard and as such should not be used and in no case looked at.
Let's see if you have what it takes. By answering the questions I will ask, we will approach the code I mentioned together.
Question 1: In 'C', what is the difference between a string and a character array?
What is this, Are you smarter than a 5th grader? I choose c, wait....d**n.
Warning: Some or all of my posted code may be non-standard and as such should not be used and in no case looked at.
In a string, we can store set of words and when we compile it, the compiler automatically puts a null character while in a character array we can only store characters and we need to assign a place for the null character. Am I right?
Hardly, I despise television with a passion unrivaled by most.
Me, too. That's why I haunt this board
