Thread: problem with very basic code

This function wont work for a factorial function. Trying to figure out why.

Code:

while(i<n)
      {
           n=n*i;
           i++;
      }

i has been initialized to 1.

What has n been intialized to?
If it's preset to 0, the loop will never run.

It's taken as input from the user -

Code:

#include <stdio.h>

/*to find factorial - considering user only enters +ve integers*/

main()
{
      int i=1, n;
      printf("Enter n\n");
      scanf("%d", &n); 
      
      /*need to figure out the problem with the loop */
      while(i<n)
      {
           n=n*i;
           i++;
      }
      printf("%d", n);
      getch();
}

Originally Posted by phoenix.labs

Code:

      /*need to figure out the problem with the loop */
      while(i<n)
      {
           n=n*i;
           i++;
      }

Will the terminal condition ever be reached when both i and n are being incremented?

Oh.. That was silly. Thank You

Code:

 
#include <stdio.h>

main()
{
      int i=1, n, p;
      printf("Enter n\n");
      scanf("%d", &n); 
      
      p=n;
      
      while(i<n)
      {
           p=p*i;
           i++;
      }
      
      printf("%d", p);
      getch();
}

It works now!