Thread: Minimum/maximum number problem. Please help!

Please remove the line "min != 0;" from your program, recompile, run it.

....

Now re-read my post.

Originally Posted by AndrewHunter

Ok, so the easiest way to do this would be:

Code:

num = GetInteger();
max=min=num;
while.....

And != does not work as an assignment operator.

Every way I test my program it works with != 0. Is there any instance where if I input something it doesn't work? Seems to me that it's just not grammatically correct.

Originally Posted by nonpuz

Please remove the line "min != 0;" from your program, recompile, run it.

....

Now re-read my post.

Oh, I am sorry. I never said what you said was wrong, I just said my way worked. I now realized that min = 0 is unnecessary. It is no longer in my code.

Here is what my code now looks like:

Code:

#include <stdio.h>
#include "genlib.h"
#include "simpio.h"

main()

{
      int min, max, num;
      
      printf ("This will compute the minimum and maximum number in the list.\nSignal the end of the list with 0.\n");
      printf ("Enter your first number: ");
      num = GetInteger();
      max = 0;
      while (num!=0)
      {
            if (num < min)
            min = num;
            if (num > max)
            max = num;
            printf ("Enter your next number: ");
            num = GetInteger();
            }
            printf ("\nThe maximum number in the list is %d.\n", max);
            printf ("The minimum number in the list is %d.\n", min);
            getchar();
      }

I'm pretty sure that it is flawless now. Correct me if I am wrong.

Originally Posted by AndrewHunter

Well, let's see I ran this:

Code:

#include <stdio.h>

int main(void){

     int num;

     num != 0;

     printf("%d", num);

     return(0);
}

and my output was -858993460.


The variable hasn't been initialized so anything you try to compare it with will result in undefined behaviour. Which means no one knows what it will do. I guarantee that this will not be accepted by your teacher. It isn't gramatically correct because it isn't an assignment operator, thus you never put any value into your variable min.

Is my code correct now? ^^

Originally Posted by PYROMANIAC702

EDIT: And of course this:


I'm sort of confused on this one. Are you talking about max = 0? If I don't have that then the program doesn't work.

EDIT: I get it now.

Code:

#include <stdio.h>
#include "genlib.h"
#include "simpio.h"

main()

{
      int min, max, num;
      
      printf ("This will compute the minimum and maximum number in the list.\nSignal the end of the list with 0.\n");
      printf ("Enter your first number: ");
      num = GetInteger();
      max=min=num;
      while (num!=0)
      {
            if (num < min)
            min = num;
            if (num > max)
            max = num;
            printf ("Enter your next number: ");
            num = GetInteger();
            }
            printf ("\nThe maximum number in the list is %d.\n", max);
            printf ("The minimum number in the list is %d.\n", min);
            getchar();
      }

Is this correct?

yes it is correct now...

Originally Posted by AndrewHunter

Code:

main()

{
      int min, max, num;
      
      printf ("This will compute the minimum and maximum number in the list.\nSignal the end of the list with 0.\n");
      printf ("Enter your first number: ");
      num = GetInteger();
      max = 0;
      while (num!=0)
      {
            if (num < min)WHAT IS THE VALUE OF MIN RIGHT NOW?
            min = num;
            if (num > max)
            max = num;
            printf ("Enter your next number: ");
            num = GetInteger();
            }
            printf ("\nThe maximum number in the list is %d.\n", max);
            printf ("The minimum number in the list is %d.\n", min);
            getchar();
      }

The easiest way to do this is:

Code:

printf ("This will compute the minimum and maximum number in the list.\nSignal the end of the list with 0.\n");
      printf ("Enter your first number: ");
      num = GetInteger();
      max = min=num;
      while (num!=0)
      {....

This way before entering your while loop max and min are both initialized to a value, namely the first number entered. Which if you follow the logic of how you would do it by paper works. Watch keep track of max and min for me, ready?

First number: 5

So what is the max and min of the number sequence I gave you?

I understand your frustration. I am a coding newbie (as you can tell) and everything you say to me really means a lot and I respect every word that you say. I added the part you told me to in the post above in the EDIT. I hope I did it right.

Originally Posted by subhash.rao

yes it is correct now...

GREAT! Thank you guys so much!!!

Originally Posted by AndrewHunter

It's ok, I'm not getting frustrated I was just trying to show you where in the code and it is hard to do without caps and colors. The code in the edit looks good, as long as you understand the logic. Is this a summer program thing?

No, I just really wanted to learn how to program so I signed up. It's all year round, but you buy each class. This one is for 3 months and It ends August 1st.