Thread: guys i really need help! else if ..

Thnx all! especially to Lasterlight , it works

This is not "random", unless you are saying that the structure of the flow of control in your code is "random".

In his defense, I think he was using the term "random" facetiously.

You have to do that anyway when coding with respect to say, C89.

Not that anyone cares, but the old style is my own personal preference.

The old style is old for a reason. A better style was developed~ there is documented proof that improvements in style formats like declaring variables close to the initial use drives down possible bugs and creates more readable code. The end result is less work which translates to less money being consumed by the project.

The old style is of course important to understand and work with from time to time.

Originally Posted by Justin Chan

Code:

#include<stdio.h>

int main()
{
       
       char name[30],rcode,D,d,s,S,T,t;
       float rprice,price;
       int days;
       
       printf("------------------------------------------\n\tWELCOME TO LEGEND HOTEL\t\t\n------------------------------------------");
       printf("\nRooms : Delux(D)  Twin Sharing(T)  Single(S)\n\n");
       printf("Enter your name\t\t :");
       gets(name);
       printf("Enter Room code\t\t :");
       scanf("%c", &rcode);
       printf("Enter number of days\t :");
       scanf("%d", &days);
       printf("\n\n------------------------------------------\n\tPAYMENT RECEIPT\t\t\n------------------------------------------\n");
       
       
       
             if(rcode == D || d)
             {rprice = 200.00;
             price = rprice * days;
             printf("Customer Name\t: %s\n", name);
             printf("Room Type\t: Delux\n");
             printf("Room Price\t: %.2f\n", rprice);
             printf("Number of days\t: %d\n", days);
             printf("Bill\t: RM%.2f\n", price);
             }
             else
             if(rcode == T || t)
             {rprice = 170.00;
             price = rprice * days;
             printf("Customer Name\t: %s\n", name);
             printf("Room Type\t: Twin Sharing\n");
             printf("Room Price\t: %.2f\n", rprice);
             printf("Number of days\t: %d\n", days);
             printf("Bill\t: RM%.2f\n", price);
             }
             
             else
             if(rcode == S || s)
             {rprice = 120.00;
             price = rprice * days;
             printf("Customer Name\t: %s\n", name);
             printf("Room Type\t: Single\n");
             printf("Room Price\t: %.2f\n", rprice);
             printf("Number of days\t: %d\n", days);
             printf("Bill\t: RM%.2f\n", price);
             }
             else
             {price = 0;
             price = rprice * days;
             printf("Customer Name\t: %s\n", name);
             printf("Room Type\t: Invalid\n");
             printf("Room Price\t: %.2f\n", rprice);
             printf("Number of days\t: %d\n", days);
             printf("Bill\t: RM%.2f\n", price);
             }
       
       
       
       
       
       
       
       
       
       system("pause");
       getche();
       return 0;
       
       
       }

First, turn the warning levels on your compiler to their maximum ... then treat every warning as an error to be fixed. You'll be amazed how smart your compiler is about helping you write better code. It should be complaining about uninitialized variables, unused variables and invalid conditional statements...

For example...

Code:

             if(rcode == D || d)

... simply isn't going to do what you want it to.

You are obviously wanting to compare the rcode which is typed by the user to find out which letter they've entered. You do that like this...

Code:

if (rcode == 'D' || rcode == 'd')

... comparing the value of rcode to character constants, not other variables.

This of course means that your D,d,s,S,T,t variables are unused in the program and can be removed.

Also you have a large amount of redundent code in your program. For example, you only need to display the customer name and number of days once before entering your if/else if sequence, not on every branch of it.

Originally Posted by laserlight

Agreed: ability != style


Better than what? I'd say that that is not better than:

Code:

int number;
printf( "enter a number: " );
scanf( "%d", &number );

Since the printf is related to the scanf and it is unlikely that code that might access number would be inserted in between, so the declaration just before the printf is still sufficiently near first use. However, it is better than:

Code:

int number;
/* ... several lines of code that does not involve number ... */
printf( "enter a number: " );
scanf( "%d", &number );

I feel like you understand what I have been saying. I don't know why Quzah isn't getting it.

For now on, I will just suggest people read a good styles book-- such as Code Complete.

Once again, you don't put declarations randomly or scattered at all. You choose the most logical location that is close to the use of it.

The objective is to not have code like this:

Code:

int main(void)
{
  int i, counter;

  /* 100 lines later */

  counter = 10;
  for(i = 0; i < counter; i++)
    printf("%d\n", i);

  return 0;
}

Instead we do like this:

Code:

int main(void)
{
  /* 100 lines later */

  int i, counter = 10;
  for(i = 0; i < counter; i++)
    printf("%d\n", i);

  return 0;
}

My own opinion is that it's just more organized to keep all the variables located at the top of the block. If this causes confusion or "error because I may have assigned it to something else between here and up there," then that just means I would have to correct and learn from that error.

This is largely about personal preference. I prefer the old ways myself.

The objective is to not have code like this...

No, the objective is to have clean, organized code with a consistent style that works the way it should.