Thread: Reading from file strange problem

Originally Posted by quzah

It sure is too bad no one else suggested any alternative to what you were doing in this thread.


Quzah.

As we say in Greece,τελος καλα ολα καλα which means that we succeded in the end of story

Ok,i put the terminating '\0' .However program is not correct again.I noticed that every time i read a line in the loop of while,if the position was before held by a letter and now it has to be overwritted by tab,causes the problem.
e.g (the names are seperated by tab,but bellow i have put space)

Code:

Wood Gina
Ray Vickie
Cobb Dale

Then these are going to be saved as

Code:

Wood Gina
Rayψ Vickie
Cobb Dale

When i write Rayd instead of Ray everything is ok.When i write Ra instead of Ray i get

Code:

Wood Gina
RaQψ Vickie
Cobb Dale

That means you didn't do the terminating \0 very well.

Originally Posted by tabstop

That means you didn't do the terminating \0 very well.

Maybe you are right . This is my function to do the job.s points at the beggining of string,size is the length of name e.g. Ray has size_for_malloc=3

Code:

char *put_NULL_at_end(char *s , unsigned int size_for_malloc)
{
	s+=size-1;
	s='\0';
	return s;
}

I don't know why you are subtracting one. Returning s could be dangerous depending on whether you actually use the return value, since at the end of the function s points to the null character.

Originally Posted by tabstop

I don't know why you are subtracting one. Returning s could be dangerous depending on whether you actually use the return value, since at the end of the function s points to the null character.

It has to do with length of name.Maybe i have to erase -1.However with -1 or not the problem is the return.I am going to try to pass arg 1 as char**

You don't really have to do that -- passing a char* is fine, since the individual char's themselves are editable, which is the point. But if you had been doing something like

Code:

name = put_NULL_at_end(name, 4);

then the return would trash name.

Code:

void put_NULL_at_end(char **s , unsigned int size_for_malloc)
{
	*s+=size_for_malloc;
	**s='\0';
}

Does this seems ok?

That should work, since I think we have size_for_malloc calculated correctly up above, and hopefully you are using it after every strncpy.