Thread: Having trouble passing parameters

Hi i am having some trouble passing parameters to a function. I worked out this code in the main but now i am trying to tidy up my code to make it more readable.
Please ignore the magic numbers or unused variables at the moment. Also all files are linked correctly between each other just not shown in Code.

Code:

int main(int argc, char* argv[])
{
    char *menuData;
    char menuBuffer[1000], subMenuBuffer[500];
    char *subMenuData;
    int temp, validation, count = 0;
    GJCType menu;


    if (argc != IMPORT) {
        printf("usage: %s menu.dat submenu.dat", argv[0]);
    } else {

        FILE *menuFile = fopen(argv[1], "r");
        FILE *subFile = fopen(argv[2], "r");

        if ((validation = fileImporter(menuFile, menuBuffer[0])) != TRUE) {
            fprintf(stderr, "Buffer inport failed \"menuFile\"");
        }
        if ((validation = fileImporter(subFile, subMenuBuffer[0])) != TRUE) {
            fprintf(stderr, "Buffer import failed \"subfile\"");
        }

    }

    return EXIT_SUCCESS;
}

other file.

Code:

int fileImporter(FILE* file, char* buffer)
{
    int temp;
    int count = 0;
    if (file == FAILED) {
        printf( "Could not open menu.dat\n");
        return FALSE;
    } else {
        while ((temp = fgetc(file)) != EOF || !feof(file)) {
            printf(temp);
            buffer[count] = temp;
            count++;
        }
        buffer[count] = '\0';
        fclose(file);
        return TRUE;
    }
}

Code compiles fine but when executed the program crashes.

1) Check your file opens in the first file, right after you open them and it's NULL not FAILED... not the second one.
2) I trust you wrote a .h file prototypeing your function and included it in your first file.
(Frankly, with such a trivial amount of code, I'd just put FileImporter() above main in the first file and call it a day)

Originally Posted by quzah

Code:

        if ((validation = fileImporter(menuFile, menuBuffer[0])) != TRUE) {
            fprintf(stderr, "Buffer inport failed \"menuFile\"");
        }
        if ((validation = fileImporter(subFile, subMenuBuffer[0])) != TRUE) {
            fprintf(stderr, "Buffer import failed \"subfile\"");
        }

Remove that.


Quzah.

?? this calls the function

The code was failing at the buffer[count] = temp line in the ImportFile function

Originally Posted by TonyG

The code was failing at the buffer[count] = temp line in the ImportFile function

Actually, it's probably failing here:

Code:

printf(temp);

You need to read the docs on printf. You don't get to pass it whatever you feel like. temp is an int, but printf needs a char * as the first parameter. You can pass your int/char for printing as a second parameter, so long as you give the right format string for the first parameter.

EDIT: And you still need to follow Quzah's advice from post #3. He's telling you to remove the magenta text only. The [0] passes in a single char. You want to pass in a pointer to the first element, so use the name of the array only.

Probably because we are learning. I don't even know what Match the Colors exercise means?

printf(temp);
Sorry that was only in there for debugging. It was still failing with out it. Ignore that line

You still need to follow Quzah's advice from post #3. He's telling you to remove the magenta text only. The [0] passes in a single char. You want to pass in a pointer to the first element, so use the name of the array only, like so:

Code:

if ((validation = fileImporter(menuFile, menuBuffer)) != TRUE) {

Notice how I just use menuBuffer instead of menuBuffer[0]? That's what he meant.

...Sorry for thinking to hard on something. Have only been at my computer for 7 hrs straight coding.

Originally Posted by quzah

Seriously? What is confusing about me highlighting a specific spot of your code in color, and then saying remove that? I give up. You're too dumb for this.


Quzah.

Originally Posted by TonyG

Probably because we are learning. I don't even know what Match the Colors exercise means?

He said to take out the text he marked in that ugly arsed purple he likes so much.

Originally Posted by TonyG

...Sorry for thinking to hard on something. Have only been at my computer for 7 hrs straight coding.

Ahhh... working a short day I see.... Must be nice.

Glad im not the only one that felt

Seriously? What is confusing about me highlighting a specific spot of your code in color, and then saying remove that? I give up. You're too dumb for this.

was a little out of line. Guess Aunty Flow is in town.