In what sense? The only difference I see between your version and the OP's is that you put the parameters on one line and added some whitespace.Originally Posted by CommonTater
I rarely do it, but I have seen lots of code where parameters always get one line each; there is nothing unacceptable about that (it's much more likely that advocates of the approach would poo-poo squeezing parameters onto one line, LOL).
C programming resources:
GNU C Function and Macro Index -- glibc reference manual
The C Book -- nice online learner guide
Current ISO draft standard
CCAN -- new CPAN like open source library repository
3 (different) GNU debugger tutorials: #1 -- #2 -- #3
cpwiki -- our wiki on sourceforge
I didn't say it was unacceptable... only that it's unusual.
When I write code, the background question is always ... "And if I have to come back to this in 5 years, will I still be able to follow it?"
And, in case you didn't notice, I also apologized for my initial mistake in misinterpreting his code...
More importantly, as has been made apparent in THIS case, "If I want others to comment on it, will they be able to follow it?"When I write code, the background question is always ... "And if I have to come back to this in 5 years, will I still be able to follow it?"
That said, I believe there's actually a style standard that has the parameters listed that way. Don't recall where it might be used, or what it might be called.
It just seemed a little devious because it is a recognizable (and IMO common) style. It would be like me seeing some newbie using an Allman style and saying, "your indentation is tedious and wastes space, no one likes that, you should do it like me", because I'd rather read stuff in K&R. In a less idiosyncratic reality, I personally may not like Allman much, but I can't claim it's bizarre or unconventional.
No indention or random indentation is another thing.
C programming resources:
GNU C Function and Macro Index -- glibc reference manual
The C Book -- nice online learner guide
Current ISO draft standard
CCAN -- new CPAN like open source library repository
3 (different) GNU debugger tutorials: #1 -- #2 -- #3
cpwiki -- our wiki on sourceforge
Ok you win... can we get back to helping the OP now?
Yikes I didn't mean to start a religious war D: . Kidding aside, the solution I posted earlier - after confirming it with some tests - seems to do the trick. Thanks again for all the help.
No worries... sometimes we do get a little carried away.
I misread your code (that happens too)... my bad. But some people need to learn when the argument is over.
