To copy chars to a array perfectly

**rukshan** · 04-13-2011

im new to c programming.i tried to get char inputs and assign them to char array.and then i printed that array.but when printing it shows another characters also after given chararcters.if can somebody help me to solve this il be very great ful to you.(pleas show me how to make char array from input)
my code is

Code:

#include<stdio.h>
#define MAX 100

main()
{
    char s[MAX];
    int c;
    int i=0;
    
//assign to char array
     while((c=getchar())!='\n')
    {
    s[i]=c;
    i++;
    }

//print char array
    int p=0;
    while(s[p]!='\0')
    {
        printf("%c",s[p]);
        p++;
    }
}

whe i give input as example i wrote in command prompt "rukshan"
output is "rukshan#$^&*^"

please help me
thanx

output is

**Salem** · 04-13-2011

You don't do a s[i] = '\0'; anywhere.

So this
while(s[p]!='\0')
stops at some random later location, printing garbage as it goes.

**rukshan** · 04-13-2011

thank you mr salem .in c programming languages book by kerninigan and ritche it says every string is array a of characters.so in their example is like this(to find length)

int strlen(char s[])
{
int i;
while (s[i] != '\0')
++i;
return i;
}

that means after a characters in char array they put '\0' at suffix.isn`t it? then ywhy here it is wrong please explain me.thank you very much.

**rukshan** · 04-13-2011

i changed the code as follow.but it remains(i change '\0' to'\n').please some body help me.
#include<stdio.h>
#define MAX 100
int strlen(char s[]);
main()
{
char s[MAX];
int c;
int i=0;

while((c=getchar())!='\n')
{
s[i]=c;
i++;
}

int p=0;
while(s[p]!='\n')
{
printf("%c",s[p]);
p++;
}

}

**rukshan** · 04-13-2011

finally i found it.its about <string.h>.thank you mr salem for the help.

**Fader_Berg** · 04-13-2011

You're gonna gonna find yourself in big trouble later.
As Salem said, you've got to put a '\0' in there. '\0' is a terminator for strings in C. You may end the printing at any character you want, but so see to it that all strings ends with '\0'.

Code:

[...]
//assign to char array
    while((c=getchar())!='\n')
    {
    s[i]=c;
    i++;
    }

    s[i] = '\0';
[...]

**rukshan** · 04-13-2011

thank you very much MR.fader.i got it.thanx again

**mike65535** · 04-13-2011

Originally Posted by rukshan

book by kerninigan and ritche it says every string is array a of characters.

No.

Hope you got it straight that a string is an array of chars with a '\0' at the end.

No '\0' = no string.

Thread: To copy chars to a array perfectly

Thread Tools

Search Thread

Display

To copy chars to a array perfectly

Similar Threads

How come this works perfectly? Replacing a 2d character array with 1d array.

program working perfectly, but array is giving me a little problem

cin to array of chars

Array of pointers (chars)

How to encrypt a CD perfectly?