Thread: Counting numbers of upper and lower case letters in C programming?

Hi,
I was working on a program which count #'s of upper and lower case letters, digits and # of all special characters in a sentence a user enters. So, here is what I got so far:
#include <stdio.h>
#include <ctype.h>
#include <string.h>

int main()
{
char str[30];
int len;
int i;

printf("\nEnter a sentence:");
gets(str);
len = strlen(str);

for (i=0; i<len;i++){
if (isalpha(str[i])){
printf("\nstr[%d] is alpha", i);
if (islower(str[i]))
printf("\nstr[%d] is lowecase",i);
else
printf("\nstr[%d] is upper", i);
}
if (isdigit(str[i])){
printf("\nstr[%d] is Digit", i);
}
else
printf("\nstr [%d] is Not alpha nor digit");
}
return 0;
}

Thanks

My question is, how to count and display the number of lower and upper letters entered by the user (gets(str)). I tried this code but its not working. I am guessing i am missing something.

Keep a counter of upper and lower case letters...

Code:

int cnt_upper = 0, cnt_lower = 0;

Then inside the if block where you determined whether something is upper / lower, just add 1 to the counter.

I tried that and when you run the program it start a endless loop. Can you explain lil more clearly?
Also, just to make sure that I am writing this program in C language.

Please post your updated code. Intent properly and use code tags.

There we go again ...

Code:

#include <stdio.h>
#include <ctype.h>
#include <string.h>

int main()
{
	char str[80];
	int countUpper = 0;
	int countLower = 0;
	int len;
	int i;

	printf("\nEnter a sentence:");
	gets(str);
	len = strlen(str);
	
	for (i=0; i<len;i++){
	if (isalpha(str[i])){
	printf("\nstr[%d] is alpha", i);
	if (islower(str[i])){
	printf("\nstr[%d] is lowecase",i);
	i = countLower + 1;
	}
	else 
	printf("\nstr[%d] is upper", i);
	i = countUpper + 1;
	}
	if (isdigit(str[i])){
	printf("\nstr[%d] is Digit", i);
	}
	else
	printf("\nstr [%d] is Not alpha nor digit");
	}
	return 0;
}

Your indentation is still off. Get an editor that auto-indents and does syntax highlighting, and errors like this will jump out at you. You're missing some braces:

Code:

#include <stdio.h>
#include <ctype.h>
#include <string.h>

int main()
{
    char str[80];
    int countUpper = 0;
    int countLower = 0;
    int len;
    int i;

    printf("\nEnter a sentence:");
    gets(str);
    len = strlen(str);

    for (i=0; i<len;i++){
        if (isalpha(str[i])){
            printf("\nstr[%d] is alpha", i);
            if (islower(str[i])){
                printf("\nstr[%d] is lowecase",i);
                i = countLower + 1;
            }
            else {
                printf("\nstr[%d] is upper", i);
                i = countUpper + 1;
            }
        }
        if (isdigit(str[i])){
            printf("\nstr[%d] is Digit", i);
        }
        else
            printf("\nstr [%d] is Not alpha nor digit");
    }
    return 0;
}

Code:

	i = countLower + 1;
...
	i = countUpper + 1;

Also, those lines are wrong. You're changing the value of i instead of countLower and countUpper. Replace them with

Code:

countLower++;
countUpper++;

Code:

	printf("\nstr [%d] is Not alpha nor digit");

You need another parameter to printf. Pass in i.

Please don't just post code without any question or explanation. I can only assume that it's still not working correctly. How about you fix your indentation and see if you can spot anything? Also, for the third and final time, stop using gets. There's a great explanation of why it's bad and how to fix it here.

If you can manage to fix your indentation and usage of gets, and still have trouble locating your problem, then post your updated (no gets and correct indentation) code, and I will help you. But if you don't listen to me, why should I listen to you.