Thread: Trouble with strings!

does anybody know why strings change during the program execution?
example. :
cprintf("%s","This is the string i want"); <- program calls this function several times during programs execution, and the result is diferent to that i've written.

i mean :
This is the string i want
This is the string i want
"lkj24?#@\]20x223" or part of other strings that i use.


I can mention that i use a lot of strings ( type [char *]).

i will not paste the code because it's to big.
if smb have an ideea pm, ill send code..

Post the smallest part of your code that demonstrates the problem...
In particular we will need to see how you are creating/declaring your strings.

Most likely the strings are changing because you are using them uninitilized or without memory allocations.

It looks like you are having memory corruption. Usually outdated compiler will allow to modify string literal.
Use your debugger/memory checker and start working. Writing program is just part of development!
Argh salem beats me up! I'm having slow connection here.:-|

Originally Posted by CommonTater

Post the smallest part of your code that demonstrates the problem...
In particular we will need to see how you are creating/declaring your strings.

Most likely the strings are changing because you are using them uninitilized or without memory allocations.

well i'm just using them like this :

cputs(": Den. : : Nr. : :Nr. Mem. : :Conducatorul: :Orientare:");

or

cprintf("%s",":Partidului: :Membri: :Parlament: : Partidului :");

do i need to use all strings like this :
s1=(char *)malloc(40);
strcpy(s1,"Vizualizarea Partidelor si Membrilor");

(even if there's no need to modify, cause these strings are somethings like header of a table that i'm drawing/writing on screen )?

and what about
cprintf("%c",185) ?
if it also write's parts of strings, ho do i solve, this problem?

Originally Posted by picaso

well i'm just using them like this :

cputs(": Den. : : Nr. : :Nr. Mem. : :Conducatorul: :Orientare:");

or

cprintf("%s",":Partidului: :Membri: :Parlament: : Partidului :");


do i need to use all strings like this :
s1=(char *)malloc(40);
strcpy(s1,"Vizualizarea Partidelor si Membrilor");

(even if there's no need to modify, cause these strings are somethings like header of a table that i'm drawing/writing on screen )?

and what about
cprintf("%c",185) ?
if it also write's parts of strings, ho do i solve, this problem?

Most likely you have 1 or 2 strings someplace where you've failed to initialize memory, leaving the pointers aimed at undefined locations in which case you get undefined behavior. Most often it's not the literal string you print that's causing the problem. Something is overwriting literal strings... you need to find out what that is.

Originally Posted by Salem

Stop looking at where the problem shows up, and methodically look at ALL your other usage of char pointers.

Somewhere, you have
- not initialised a pointer
- not allocated enough memory
- tried to use it after freeing it
- tried to free something twice
- tried to free something which wasn't allocated.

The "not enough memory" also applies to all your char arrays as well, especially static/global arrays.

i'm not looking where problem show's up, and paste it here.
i asked about char (single caracter).

In your loop check carefully that you don't have buffer overrun or any...