Thread: Sorting 3 arrays alphabetically

What's wrong with this code?

Code:

  char tcognome[40];
  char tnome[40];
  int tnum;
  int sorted[STRMAX];
  int rank[STRMAX];
for (j = 0; j <cnum; ++j)
  {
    rank[j] = 0;
    for (i = 0; i < cnum; ++i)
      rank[j]+=(punteggio[i]>punteggio[j]);
  }
  
/* sort elements */
 for (i = 0; i < cnum; i++)
   {
    sorted[rank[i]]=punteggio[i];
    if (rank[i]>rank[i+1]){
         strcpy(tnome,nome[i]);
         strcpy(nome[i],nome[i+1]);
         strcpy(nome[i+1],tnome);
 
         strcpy(tcognome,cognome[i]);
         strcpy(cognome[i],cognome[i+1]);
         strcpy(cognome[i+1],tcognome);
}
   }

 printf("4. Outputting contestents' ranking: [in descending order]\n");
 /*   output */
  for (i = 0; i < cnum; ++i)
    printf("Points:%d   First name:%s   Last name:%s\n",sorted[i],nome[i],cognome[i]);

it sorts points right, but again, names aren't associated. That was my try. Any hints?

You have the outer for loop closing, before you start the second for loop. They need to be nested, one inside the other.

There might be other issues as well. Messing around with "your own" sorting algorithm, is like trying to make your own medicine's, at home -- not a great idea unless you are experienced, and have lots of time, too.

Yeah that didn't fix it. I wonder why.
I tried this also:

Code:

for ( i = 0; i <cnum; i++) {
   for (j = i+1; j<cnum; j++) {  
 if(rank[i]>rank[j])
   {
       strcpy(tnome,nome[i]);
         strcpy(nome[i],nome[j]);
         strcpy(nome[j],tnome);
   }
   }}

It works for 5-6 but then it's wrong.

You're just swapping names then, but keying on rank? That just scrambles your data. Study how the one I gave you, works.

Code:

   for ( j = 0; j < cnum -1; j++){
    posMin = j;

    for (i = j+1; i < cnum; i++)
      if (strcmp(cognome[i], cognome[posMin]) < 0)
	posMin = i;

    strcpy(tmp1,cognome[j]);                              
    strcpy(cognome[j],cognome[posMin]);
    strcpy(cognome[posMin],tmp1);

    strcpy(tmp1,nome[j]);                              
    strcpy(nome[j],nome[posMin]);
    strcpy(nome[posMin],tmp1);
 
     tnum=punteggio[i];
     punteggio[i]=punteggio[j];
     punteggio[j]=tnum;
   }

You mean? Didn't work.

I've been sitting on my laptop for 7 straight hours so excuse my blindness. I don't know.

Code:

    tnum=punteggio[posMin]; 
    punteggio[posMin]=punteggio[i];
    punteggio[i]=tnum

Again, I'm a beginner. I'll try again.

What else is there that you need? I thought you were done.

Just a part of this whole sorting algorithm. I sorted the points but i'm facing the same problem of associating their respective names. I made it work for 5-6 names as I told you before but past that it's wrong :/

You do realise this is a new request related to the original one in my 1st post, yet DIFFERENT?
So how could it have been solved in post 6 when I asked for it a few posts ago?
First I had to sort according to last name and then associate their points, now it's the opposite. Sort by points and associate respective names.