Thread: Rookie looking for help!

I am not indenting anyways... Sorry. Next time i'll definitely indent it... Sorry again....

I am not sure, where exactly you are replacing this code in your original source code. If you can come up with your original source code, that will be much appreciated...
*Waiting*

Originally Posted by Adak

You have to record one of three states, for each number. Your logic should be something like this.

I tried following that, and got this:

Code:

    for(i=0; i<ARR_SIZE; i++)
    {
        if( guess[i] == secretNumber[i] )
        {
            help[i] = 'R';

        }

        for (j=0; j < ARR_SIZE ; j++)
        {
            if (guess[j] == secretNumber[i] && j != i)
            {
                help[i] = 'S';
            }
        }

        if (help[i] != 'R' && help[i] != 'S')
        {
            help[i] = '_';
        }
    }

It didnt't work though, but im not sure i got it all right... :S

When i tried it and got the secretNumber array 4 6 5 3, and made the
guess array 4 4 4 4 , it returned S _ _ _, when it should have returned S S S S...

Also when the secretNumber array was 1 3 6 5 and guess array was 1 2 3 4
it returned R S _ _ when it should have returned R _ S _

Originally Posted by Adak

@Newklear:

I didn't understand the help[] array in your code snippet. Your code looks very close to what I put up in pseudo code, however.

the help[] array should contain the characters R, S or _ depending on what you guessed... it should be the same as the state[] that you used in your pseudo code i think

I'll paste the current code unto pastebin again... line 80 to 102

The code

This is making me crazy, btw >.<

Originally Posted by Newklear

I tried following that, and got this:

When i tried it and got the secretNumber array 4 6 5 3, and made the
guess array 4 4 4 4 , it returned S _ _ _, when it should have returned S S S S...

Well, with Number[]={4,6,5,3}, and guess = 4,4,4,4, the answer would have to include at least one R.

The way I did mine, if a number was guessed correctly, it did not get compared to other non-guessed numbers. So my programs returns: R___ in this case.

Let me refine my program code, so the correct answer would be RSSS in this case, right?

It's a great exercise in logic though. Good on your teacher or book for challenging you with it.

Back in a bit.

It's late and I'm bushed, but this is what I have:

Code:

#include <stdio.h>
#define MAX 4

int main(void) {

  int i, j, guess[MAX]={0}, numRight=0, n[MAX]={1,3,6,7};
  char state[MAX+1]={""}; 
  while(numRight < MAX) {
    
    printf("\n\nTo be guessed: %d. Guessed correctly: %d\n\n", (MAX-numRight),numRight);
   
    printf("\n What's your guess? ");
    for(i=0;i<MAX;i++)
      scanf("%d", &guess[i]); 
    (void) getchar();
    numRight = 0;
    for(i=0;i<MAX;i++) {
      if(guess[i]==n[i]) {
        state[i]='R';    
        numRight++;
      }      
      else {
        for(j=0;j<MAX;j++) {
          if(guess[i]==n[j] && j != i) 
            state[i]='S';
        }
      }         
      if(state[i] != 'R' && state[i] != 'S')
        state[i]='_';
    }
    printf("\n %s", state);    
  }
  printf("\n\n\t\t\t    press enter when ready");
  (void) getchar();
  return 0;
}

Try that kind of logic out. Any changes will have to be done tomorrow as I'm off to bed. You have to break out with Control+C or Control+break keys, if you want to quit before solving all the numbers. Sorry about that.

I tried following that, and got this:

When i tried it and got the secretNumber array 4 6 5 3, and made the
guess array 4 4 4 4 , it returned S _ _ _, when it should have returned S S S S...

Infact it should return RSSS.
The reason is, after making the first decision of R, it comes inside the loop (with variable j) and executes itself....
So instead of doing guess[j]==secretNumber[i] i'll recommend you to do guess[i]==secretNumber[j] and also inside the first if from line number 84 to 88, you should set a flag that will not allow the program to enter in the loop(with variable j) if program has been entered in the if.....