Problem with printing arrays

**anxty** · 01-10-2011

The problem im having is, my program takes the name (and various other details) in from a data file. Works out the total price for each week (adding if there are two or more sales in one week) and then outputs the total along with the week number. That all runs perfectly.

The hard part is when I try to print the largest single sale. I successfully print the week number, the price and the number of units. However I cant work out how to print the name. my fprintf statement is as follows.

Code:

 
fprintf(output, "\nThe largest single sale was in week %i, when %i units of %s were sold at %g per unit.\n", largest.week, largest.units, &largest.name[0] (float)largest.price/100) ;

Any help is appreciated.

**nimitzhunter** · 01-10-2011

Is Largest.name[0] char* ?

**grumpy** · 01-10-2011

Assuming largest.name is an array of char, instead of "&largest.name[0]" use the (equivalent) "largest.name".

If largest.name is a pointer, the same applies, but you need to allocate storage to hold the data read in from the file (pointers don't magically point at anything unless you make them do so).

Then add a comma immediately after (before "(float)largest.price/100"). It is that missing comma that is making your compiler complain.

**anxty** · 01-10-2011

its part of a struct

Code:

 struct sale
  {
    int week  ;
    char name[30] ;
    int units ;
    int price ;
    int total ;
  } ;

basically, I want to limit it to 30 characters, ive tried using %30s in the past, however it limited it to 30 but also required 30 characters to be entered, which obviouslly isnt helpful :P

as for the comma, its there in the program, must have deleted it while I was copying it accross

program compiles and the response I get is

The largest single sale was in week 0, when 514 units of Ú· were sold at 3.25 per unit.

**vart** · 01-10-2011

Originally Posted by anxty

I want to limit it to 30 characters, ive tried using %30s in the past, however it limited it to 30 but also required 30 characters to be entered

I do not get it how limiting the output of the string to 30 chars also requires to input 30 chars during input? there are 2 different operations with 2 different limitations...

also your array is suitable to store only 29 chars long strings (since you need a place for nul-terminator).

**anxty** · 01-10-2011

Im not sure why it did that either. Obviouslly I did something wrong from the start.

though right now im more concerned with printing a name read from input.

I dont know how to do it, all my attemps just get an odd output. I can show all of my code if that will help?

**laserlight** · 01-10-2011

Originally Posted by anxty

I can show all of my code if that will help?

Yes, though if it is too long, show the smallest and simplest compilable program that demonstrates the problem.

**anxty** · 01-10-2011

Code:

#include <stdio.h>
#include <stdlib.h>


  FILE *output ;
  FILE *input ;

  struct sale
  {
    int week  ;
    char name[30] ;
    int units ;
    int price ;
    int total ;
  } ;

  void result(int week[])
{
  for(int i = 0 ; i < 13 ; i++)
  {
    fprintf(output, "\n%i        %g", i, ((float)week[i]/100)) ;
  }
}


void close(void)
{
  fclose(input) ;
  fclose(output) ;
}



int main(int argc, char *argv[])
{

  int week[13] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0} ;


  struct sale info ;
  struct sale largest ;

  info.units = 0 ;
  info.price = 0 ;
  largest.price = 0 ;
  largest.units = 0 ;

  input = fopen(argv[1], "r") ;
  output = fopen(argv[2], "w") ;

  if(( fopen(argv[1], "r")) == NULL)
  {
    printf("Sorry, this file cannot be opened.\n") ;
    exit(1) ;
  }
  else if(( fopen(argv[2], "w")) == NULL)
  {
    printf("Sorry, this file cannot be opened.\n") ;
    exit(2) ;
  }

  while(fscanf(input, "%i%30s%i%i", &info.week, info.name, &info.units,
        &info.price) != EOF)
  {

    week[info.week] += info.units * info.price ;
    info.total = week[info.week] ;
    if(info.price * info.units > largest.units * largest.price)
      {
        largest.price = info.price ;
        largest.units = info.units ;
        largest.week = info.week ;
        info.name[info.week] = largest.name[1] ;
      }
  }

  fprintf(output, "WEEK   TOTAL SALES") ;

  result(week) ;
  fprintf(output, "\nThe largest single sale was in week %i, when %i units of %30s were sold at %g per unit.\n", largest.week, largest.units,
          largest.name, (float)largest.price/100) ;

  close() ;
}

**~~CommonTater~~** · 01-10-2011

info.name[info.week] = largest.name[1] ;

C doesn't know how to do string = string.

You probably want to use strcpy() to copy the name.

**anxty** · 01-10-2011

would it work just saying

strcpy(info.name[info.week], largest.name[1]) ;

or is that wishful thinking :P

**laserlight** · 01-10-2011

Eh, this looks wrong:

Code:

  input = fopen(argv[1], "r") ;
  output = fopen(argv[2], "w") ;

  if(( fopen(argv[1], "r")) == NULL)
  {
    printf("Sorry, this file cannot be opened.\n") ;
    exit(1) ;
  }
  else if(( fopen(argv[2], "w")) == NULL)
  {
    printf("Sorry, this file cannot be opened.\n") ;
    exit(2) ;
  }

It should be something like:

Code:

input = fopen(argv[1], "r");
if (input == NULL)
{
    printf("Sorry, '%s' cannot be opened.\n", argv[1]);
    exit(1);
}

output = fopen(argv[2], "w");
if (output == NULL)
{
    printf("Sorry, '%s' cannot be opened.\n", argv[2]);
    fclose(input);
    exit(2);
}

But you also should be checking argc before you acces argv[1] and argv[2].

Originally Posted by anxty

would it work just saying

strcpy(info.name[info.week], largest.name[1]) ;

More likely:

Code:

strcpy(info.name, largest.name);

**anxty** · 01-10-2011

ok new code reads

Code:

if(info.price * info.units > largest.units * largest.price)
      {
        largest.price = info.price ;
        largest.units = info.units ;
        largest.week = info.week ;
        strcpy(info.name,  largest.name) ;
      }

new output reads

The largest single sale was in week 0, when 514 units of Tªx· were sold at 3.25 per unit.

**laserlight** · 01-10-2011

Try:

Code:

while (fscanf(input, "%i%29s%i%i", &info.week, info.name, &info.units, &info.price) == 4)
{
    week[info.week] += info.units * info.price;
    info.total = week[info.week];
    if (info.price * info.units > largest.units * largest.price)
    {
        largest = info;
    }
}

**~~CommonTater~~** · 01-10-2011

Originally Posted by anxty

ok new code reads

Code:

if(info.price * info.units > largest.units * largest.price)
      {
        largest.price = info.price ;
        largest.units = info.units ;
        largest.week = info.week ;
        strcpy(info.name,  largest.name) ;
      }

new output reads

Code:

strcpy(largest.name, info.name);

Laserlight's solution is better...

**laserlight** · 01-10-2011

On second thought, it should be more like:

Code:

while (fscanf(input, "%i%29s%i%i", &info.week, info.name, &info.units, &info.price) == 4)
{
    week[info.week] = info.total = info.units * info.price;
    if (info.total > largest.total)
    {
        largest = info;
    }
}

The += thing kind of tricked me: you're just adding to 0, but your intention is really to assign, not to add to the current value.

Thread: Problem with printing arrays

Thread Tools

Search Thread

Display

Problem with printing arrays

Similar Threads

Pointers to arrays problem

Problem with Arrays

Problem with printing instruction pointer

Printing 2d array problem

Homework problem...structures or arrays?

Tags for this Thread