Thread: Debugging password safe thing. Need help

ok so im quite new to C and i am learning it atm, (cut me som slack). so im going thru the c for dummies book and came to the point of using scanf and printf and whas thinking to take the program one step futher. so i made it like so that if you answer correctly it will just to the next question but i had some minor bugs.
And i know 2+2=4 kinda thing but it is just not that easy for me :P hehe
Source code:

Code:

#include <stdio.h>
int main()
{
char name[20];
char color[20];
printf("What is your name?");
scanf("%s",name);
if (strcmp(name,"david") == 0);
else printf ("get away from the pc!");
printf("What is your favorite color?");
scanf("%s",color);
if (strcmp(color,"blue") == 0);
printf("%s’s favorite color is %s, oh i forgot... the password is david\n",name,color );
return(0);
}

And now the bugs

Code:

john@ubuntu:/home/prog/C$ ./safe
What is your name?idunno
get away from the pc!What is your favorite color?youarenotstopping
idunno’s favorite color is youarenotstopping, oh i forgot... the password is david
john@ubuntu:/home/prog/C$

The point is that if you answer wrong the program should end. now ive been thinking that is ther a way to make it show the text "get away from the computer" and then count down from 5 sec and close terminal ?

Any answer is welcome thank you

Code:

else {
  printf("Get away from the pc!\nShutting down in five seconds.\n");
  delay(5);  //check your compiler whether it's delay(seconds), or sleep(seconds)
}

You'll need to include the right header file to use delay() or sleep(). Check your man pages.

Originally Posted by Adak

Code:

else {
  printf("Get away from the pc!\nShutting down in five seconds.\n");
  delay(5);  //check your compiler whether it's delay(seconds), or sleep(seconds)
}

You'll need to include the right header file to use delay() or sleep(). Check your man pages.

Thx so much

Originally Posted by nesiory

Code:

#include <stdio.h>
int main()
{
char name[20];
char color[20];
printf("What is your name?");
scanf("%s",name);
if (strcmp(name,"david") == 0);
else printf ("get away from the pc!");
printf("What is your favorite color?");
scanf("%s",color);
if (strcmp(color,"blue") == 0);
printf("%s’s favorite color is %s, oh i forgot... the password is david\n",name,color );
return(0);
}

See the text I colored red above...

When you put a semi-colon after an if statement like that, it ends up doing nothing.
Also the orphaned else is not going to work either.

Try it like this...

Code:

if (strcmp(name,"david") != 0)  
  { puts("Get away from the pc!");
     _sleep(5);
    exit(0); }

// rest of code goes here

The only way to get to the rest of the code is to enter david. Everything else aborts the program.

Originally Posted by CommonTater

See the text I colored red above...

When you put a semi-colon after an if statement like that, it ends up doing nothing.
Also the orphaned else is not going to work either.

Try it like this...

Code:

if (strcmp(name,"david") != 0)  
  { puts("Get away from the pc!");
     _sleep(5);
    exit(0); }

// rest of code goes here

The only way to get to the rest of the code is to enter david. Everything else aborts the program.

Thank you so much help alot

Ok so now it is finishd

Code:

#include <stdio.h>
int main()
{
char name[20];
char color[20];
char key[20];
printf("What is your name?");
scanf("%s",name);
if (strcmp(name,"david") != 0)  
{ puts("Get away from the pc!");
sleep(5);
return(0); }
printf("What is your favorite color?");
scanf("%s",color);
if (strcmp(color,"blue") != 0)  
{ puts("Get away from the pc!");
sleep(5);
return(0); }
printf("What is the master key?");
scanf("%s",key);
if (strcmp(key,"cboard") != 0)  
{ puts("Get away from the pc!");
sleep(5);
return(0); }
printf("%s’s favorite color is %s, oh i forgot... the password is david\n",name,color );
return(0);
}

Thank you so much for all the help

Originally Posted by Salem

Not quite finished.
SourceForge.net: Indentation - cpwiki

Ok cleaned it up a bit

Code:

 
  /***************************/
 /**Program made by Nesiory**/
/***************************/
#include <stdio.h>
int main()
{
char name[20];
char color[20];
char key[20];

printf("What is your name?");
scanf("%s",name);
if (strcmp(name,"david") != 0)   		/** Change (name,"ThisChange") to change name **/
{
puts("Get away from the pc!");
sleep(5);
return(0);
}

printf("What is your favorite color?");
scanf("%s",color);
if (strcmp(color,"blue") != 0)  		/** Change (color,"ThisChange") to change color **/
{
puts("Get away from the pc!");
sleep(5);
return(0);

}
printf("What is the master key?");
scanf("%s",key);
if (strcmp(key,"david") != 0)  			/** Change (Key,"ThisChange") to change master key **/
{
puts("Get away from the pc!");
sleep(5);
return(0);
}

printf("%s’s favorite color is %s, oh i forgot... the password is david\n",name,color );
return(0);
}

No, you did not. Didn't you read the link Salem gave you?

Yes i read the link. (bizzilion times now) and i think i still quite cant gett it :?
But what about this and can someone point out what is wrong ?
Thanks.

Code:

   /***************************/
  /**Program made by Nesiory**/
 /****All Rigths Reserved****/
/***************************/

#include <stdio.h>
int main()
{
    char name[20];
    char color[20];
    char key[20];

	/**Question ........../
    printf("What is your name?");
    scanf("%s",name);
    if (strcmp(name,"david") != 0)   		/** Change (name,"ThisChange") to change name **/
    {
      	puts("Get away from the pc!");
      	sleep(5);
	return(0);
    }
	
	/**Question B**/
    printf("What is your favorite color?");
    scanf("%s",color);
    if (strcmp(color,"blue") != 0)  		/** Change (color,"ThisChange") to change color **/
    {
	puts("Get away from the pc!");
	sleep(5);
	return(0);
    }

	/**Question C**/
    printf("What is the master key?");
    scanf("%s",key);
    if (strcmp(key,"david") != 0)  		/** Change (Key,"ThisChange") to change master key **/
    {
	puts("Get away from the pc!");
    	sleep(5);
    	return(0);
    }

	/**Sulution**/				/** Change (Password is "ThisChange"\n",name,color) to change the final password **/
    printf("%s’s favorite color is %s, oh i forgot...the password is david\n",name,color );
    return(0);
}

You appear to have gotten the hang of moving things left-and-right. That is a good start, and you were consistent with it which is even better. Now you just need to fix the compile errors and you'll have something:

Code:

C:\Documents and Settings\Andrew\Desktop\temp.c:16:40: warning: "/*" within comment
C:\Documents and Settings\Andrew\Desktop\temp.c: In function `int main()':
C:\Documents and Settings\Andrew\Desktop\temp.c:19: error: `sleep' was not declared in this scope
C:\Documents and Settings\Andrew\Desktop\temp.c:19: warning: unused variable 'sleep'
C:\Documents and Settings\Andrew\Desktop\temp.c:26: error: `strcmp' was not declared in this scope
C:\Documents and Settings\Andrew\Desktop\temp.c:29: error: `sleep' was not declared in this scope
C:\Documents and Settings\Andrew\Desktop\temp.c:29: warning: unused variable 'sleep'
C:\Documents and Settings\Andrew\Desktop\temp.c:26: warning: unused variable 'strcmp'
C:\Documents and Settings\Andrew\Desktop\temp.c:36: error: `strcmp' was not declared in this scope
C:\Documents and Settings\Andrew\Desktop\temp.c:39: error: `sleep' was not declared in this scope
C:\Documents and Settings\Andrew\Desktop\temp.c:39: warning: unused variable 'sleep'
C:\Documents and Settings\Andrew\Desktop\temp.c:36: warning: unused variable 'strcmp'

I could compile and run the program completely fine under Ubuntu 10.10
No problems or errors here.

Originally Posted by nesiory

I could compile and run the program completely fine under Ubuntu 10.10
No problems or errors here.

Different platforms and OSs will have differing requirements, of course. I would include string.h anyway. It may not make a difference with this tiny program but if you push through and get into some more extensive projects, portability may well become an important issue.

I should also point out that indentation matters beyond mere cosmetics. If you ever have to come back 5 years later and re-work some code you wrote, the text layout, variable names and comments will be your best reminder of what you did "way back then". I've had this a few times in my life and on a couple of occasions I found I couldn't even read my own code... so, yeah, I got busy with correct formatting.

In general function and variable names provide clues to what a function or block of code is doing in your overall program. The level of indentation provides important clues about "code within code" nesting to show you what's inside what... Comments should explain anything that's not immediately obvious... It's just good practice and it can save a lot of time and trouble down the road.

Anyway... congrats on getting it to work...