Sorting strings into alphabetical order

[dude_tron_1982]

Hello,
I am new here just thought I could get some help I have wrote this program and it all works fine but I get this crap in runtime:

"
In alphabetical order, the names are:
`� N�
"

like I said it works and prints them all in alphabetical but if someone can explain why this ........ is printing in my program would be great.

Here is my code:

insert

#include <stdio.h>
#include <string.h>

#define NUM 11      /* number in the list */
main()
{
  int i, sorted, iter=0;
  long swaps = 0;
  char names[NUM][80];
  char temp[80];

  printf("enter (%i-1) names:\n", NUM);
  
  for (i = 0; i < 10; i++)
    scanf("%s", &names[i][80]);
  
  /* Bubble sort: */
  puts("in order, the names are:");

  do {
      sorted = 1;
       for (i=1; i<10; i++)
       {
         if (strcmp(names[i-1], names[i]) > 0)
         {
           sorted = 0;
           strcpy(temp, names[i-1]);
           strcpy(names[i-1], names[i]);
           strcpy(names[i], temp);
           swaps++;
         }
       }
       for (i=9; i>0; i--)
       {
         if (strcmp(names[i-1], names[i]) > 0)
         {
           sorted = 0;
           strcpy(temp, names[i-1]);
           strcpy(names[i-1], names[i]);
           strcpy(names[i], temp);
           swaps++;
         }
       }
       iter++;
     } while (!sorted);
  
  /* Output sorted list: */
  
  puts("\nIn alphabetical order, the names are:");     
  for (i = 0; i < NUM; i++)
    printf("%s\n", names[i]);
  printf("\n%li swaps were performed.\n", swaps);
  printf("\n%i iterations were performed.\n", iter);     
}

[CommonTater]

You've defined NUM as 11 ... when inputting you are only taking 10 strings but when printing you print NUM (11) strings... The last string will be filled with random garbage.

If you're going to define a number of elements... you should use it everywhere.

[anduril462]

There are a few problems:
1. NUM should be 10 since you only want 10 names. No magic numbers like 9, 10 or 11. Use NUM-1, NUM or NUM+1.
2. Your scanf is wrong. &names[i][80] is probably the next slot after the one you want. You should be using &names[i][0], or more simply, names[i].
3. names only needs 10 elements, so when you make NUM 10, don't declare names[NUM+1][80].

[dude_tron_1982]

Thank you code resolved used gets instead of scanf a bit dangerous but should work also got rid of the [80] and changed NUM to 10

[anduril462]

Use fgets with stdin instead. It's an easy conversion, the right thing to do, and a good habit to form.

[nonoob]

I've never seen a bubble sort like that... going through the entire array from beginning to end and then end-to-beginning. You need to review how bubble sort works.