This code is made to count words. But instead of displaying numbers of words, it prints 0.Code:#include <stdio.h> #include <stdlib.h> #include <string.h> int main() { char words[200]; int d,i,k=0; while(scanf("%s",words)==1){ k=strlen(words); d=0; for(i=0; i<k; i++) { if(words[i]=='\0') { d++; } } printf("%d",d); } return 0; }
=_=
eg;
input : hi my name is bob!
instead of
output: 4(Words)
it outputs 0000
Much help needed. Extremely newbie programmer.
Last edited by kaopei; 12-02-2010 at 07:14 PM.
You need to edit that and indent your code. You set d to 0 at the start of each iteration of the while loop.
Quzah.
Hope is the first step on the road to disappointment.
I put it inside the while loop to rest the counter everytime a new input is entered.
@_@ it keeps giving a
output for a supposed to be0000
and it doesnt print only one 0. it prints multiple 0s for what is supposed to be an integer =_=. eg:4
000 for 3 .. smth like tht
Why do you want the counter reset? Why are you trying to print it more than once, if you just want it to print once? Think about what's happening each time the loop goes through.
Quzah.
Hope is the first step on the road to disappointment.
Since i'm planning for the input to be entered multiple times. Thats why i needed to reset the value to 0.. If i don't it will take up the last value from the previous cycle.
That's not the problem though..the problem's in the output.. I tried changing the d to 1. It ended up printing multiple 1s.
Of course it prints multiple times:Every time it passes through your while loop, it sets it to 0, does stuff, and prints whatever it is. If you only want it to print once, then it needs to be out of your loop, and you need to stop resetting the value to 0 every time.Code:while(scanf("%s",words)==1){ d=0; ... other stuff ... printf("%d",d); }
Quzah.
Hope is the first step on the road to disappointment.
Are you trying to count whole words (i.e. chunks of letters/numbers separated by white space) or individual characters? Your example input of 0000 and output of 4 suggests you're counting characters. What should my output be for the input "Hello world!"? How about "This is a test"?
You are testing for words[i]==\0 you should be looking for spaces...Originally Posted by kaopei
It's a simple thing to do, count the spaces and add 1...
what do you want to print out?
d is counting number of '\0' in each word
Maybe you should start with
To learn what scanf %s actually gives you for a line of input.Code:while(scanf("%s",words)==1) { printf("The word is ==%s==\n", words); }
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
If I gave you a string with 10 words in it, how many 0s would it have?
True, assuming there is exactly 1 space between each word (and no punctuation without spaces). Look into strtok if you want, or if you want to roll your own, set a flag to designate whether you're in a word or in between words. Initialize it to off, turn it on when you hit your first letter. When you hit a non-letter or the end of string, turn your flag off and increment your word count.
Actually, it doesn't count the number of null characters. It doesn't count anything at all because the program can never reach the line of code that increments d. If you read carefully, k is equal to strlen(words), and the loop checks for for i = 0 to i < k. The null byte is at words[k], but i is never equal to k in that loop, it ends at k-1. So the code doesn't count anything.
10 zeros.. oddly.If I gave you a string with 10 words in it, how many 0s would it have?
>_< i thought the \0 stands for blank characters(Spaces?)... i changed it to ASCII dec 32.. but it still can't detect the spacesYou are testing for words[i]==\0 you should be looking for spaces...
It's a simple thing to do, count the spaces and add 1...
so i have to make it at i<=k right? >_< i see my bad..Actually, it doesn't count the number of null characters. It doesn't count anything at all because the program can never reach the line of code that increments d. If you read carefully, k is equal to strlen(words), and the loop checks for for i = 0 to i < k. The null byte is at words[k], but i is never equal to k in that loop, it ends at k-1. So the code doesn't count anything.
Actually it would have only one, at the end, where strlen() won't take you.
Nope...' \n' stands for 0... you want ' '... which will look at spaces.>_< i thought the \0 stands for blank characters(Spaces?)... i changed it to ASCII dec 32.. but it still can't detect the spaces
i.e. when looking for spaces, actually look for spaces.
Nope... you had that much right.so i have to make it at i<=k right? >_< i see my bad..
You are totally ignoring the root cause.
Read what salem had posted.
scanf %s stops reading at space.
So If you entered "hello world", scanf() will return when encountered space and you'll only have "hello". next scanf() call will give you "world".
If your definition of word is group of characters separated by space, each scanf() call gives you one word....
Last edited by Bayint Naung; 12-03-2010 at 10:17 AM.
