Thread: What is wrong with this program??

hi, im new to programming and was wondering could anyone tell me what is wrong with this program?:

Code:

#include <stdio.h>

char set_user, set_pass, user, pass;

main() {
	printf("Set your Username: ");
	scanf("%s", &set_user);
	printf("Set your Password: ");
	scanf("%s", &set_pass);
	printf("Username: ");
	scanf("%s", &user);
	printf("Password: ");
	scanf("%s", &pass);
	if ( set_user == user && set_pass == pass ) {
		printf("Welcome to your system\n");
	}
	else {
		printf("Username or Password is incorrect\n");
	}
}

Ive tried compiling with: gcc -x c '/root/Program Files/user_and_pass.c'
and: g++ -x c '/root/Program Files/user_and_pass.c'

it compiled but when i tried the program
output:

Code:

Set your Username: name
Set your Password: pass
Username: name
Password: pass
Username or Password is incorrect

Thanks in advance.

kk, thanks for that

Ok... a few things....

You've defined your username, password variables as type char ... this limits you to one character each. You need to set aside memory to hold your strings.

Code:

char set_user[32];
char set_pass[16];
...

If you don't do this you will end up overwriting parts of your program's stack or image which can lead to catastrophic failure... "Seg fault" or "Buffer Overrun"....

Once you set aside memory properly you will need to change your input statements...

Code:

scanf("%s", set_user);

... since set_user (etc) are now pointers to arrays of characters.

Finally C doesn't natively know much about strings. You cannot compare two strings using the == (is equal) operator. C doesn't know how to do that... You will need library functions such as strcmp() and stricmp() for that task.