Thread: a string program question

hi guys , this is a program to read string S1 ,go to index k, and delete the
char located in index k. but its giving me an error that declaration terminated incorrectly could anyone help me plz ? here is the code.

Code:

#include <stdio.h>
#include <conio.h>
#include <string.h>

 void delete(char x[],int size,int k)
 {
 int i;
 for(i=k;i<=strlen(x);i++)
 x[i]=x[i+1];
 strcpy(&x[k],&x[k+1]);
 }

 main()
 {
 char S1[10];
 int k;

 scanf("%s%d",S1,&k);
 delete(S1,10,k);

 getch();
 }

You should combine anduril462's observation with information provided by the error message, including the line number.

Ummm...

Why do you need strcpy() in there when you're moving the string character by character?

Or, conversely, why do you need the loop if you're doing it block style with strcpy.

Also... it should be int main(void) and main should return an int (usually 0).

Originally Posted by everyone0

this is killing me can't find a single problem with the function and still gives me same error

I suggest that you try:

Code:

#include <stdio.h>
#include <string.h>

void delete(char x[], int size, int k)
{
    int i;
    for (i = k; i <= strlen(x); i++)
        x[i] = x[i + 1];
    strcpy(&x[k], &x[k + 1]);
}

int main(void)
{
    char S1[10];
    int k;

    scanf("%s%d", S1, &k);
    delete(S1, 10, k);
    return 0;
}

If you still have a compiler error, then try:

Code:

#include <stdio.h>
#include <string.h>

void remove(char x[], int size, int k)
{
    int i;
    for (i = k; i <= strlen(x); i++)
        x[i] = x[i + 1];
    strcpy(&x[k], &x[k + 1]);
}

int main(void)
{
    char S1[10];
    int k;

    scanf("%s%d", S1, &k);
    remove(S1, 10, k);
    return 0;
}

If the error disappears, then I would guess that anduril462's suspicion is confirmed: you are compiling as C++ instead of C. If the error remains, then you either need to figure out how to fix your compiler, or you ditch your compiler.

Given the time stamps on the posts, I don't think you tried all that hard. You spent a maximum of 3 minutes, but if you take out time for reading my post, the two links I sent you and replying to the post, I'd give you 2 minutes. Not much time to look at every setting in Borland, check all the Borland help stuff and look for Borland specific forums that might cover how to play around with your settings, then actually try changing different settings and recompile.

Now that the upbraiding is done, there is not much wrong with your C code. I compiled it in gcc with -Wall -pedantic and got the follwing errors:
main.c:13: warning: return type defaults to ‘int’
main.c: In function ‘main’:
main.c:21: warning: control reaches end of non-void function

Declare main as

Code:

int main(void)

and make sure main returns a value (probably 0).

Originally Posted by everyone0

the second suggestion worked laserlight , thanks , i guess i won't have to ditch my compiler lol.

Yes, but you need to configure it to compile your C code as C, not C++. Otherwise, you either switch to C++, or you end up using a C compiler that rejects valid C programs, thus frustrating you if you don't know enough C++ to write C programs that are also valid C++ programs.

Note that 'remove' is also defined in stdio.h but I guess that's part of the joke, isn't it?
gcc -pedantic -Os -c "eek.c" -o "eek".o -std=c99
eek.c:4:6: error: conflicting types for ‘remove’

C Links (no affiliation)
C Draft Standards
http://faq.cprogramming.com/cgi-bin/smartfaq.cgi
http://rosettacode.org/wiki/Category:Programming_Tasks
http://www.iso-9899.info/wiki/Main_Page
http://clc-wiki.net/

My C Stuff (GPL):
PaperDragon
TML Version 2
Fix missing brackets with Anchor
The Nerd Show | Platypus