Thread: Program to Make nouns plural

Hey guys..

I'm writing a program that converts singular nouns to their plural form.
ie.. if the noun ends in "y" remove the "y" and add "ies"
ends in "s", "ch", or "sh" add "es"
and any other case add "s"

So i have my program listed below. I'm trying to remove the last character of the string, analyze it, then determine what action needs to take place. Does anyone have any other opinions on how to tackle this problem or any suggestion on what i've written so far?

Thanks,
dtowndream

#include <stdio.h>
#include <string.h>

int main(void)
{
char mystr[50] = {0}, tmp[50] = {0}, a[50]={0};
int x;

printf("Enter a string: ");
gets(mystr);
printf("Last char: %c\n",mystr[(strlen(mystr)-1)]);
for(x=0;x<(strlen(mystr)-1);x++)
tmp[x] = mystr[x];


if((strlen(mystr)-1)= ' y ' ){
printf("%sies\n",tmp);
}
else if(((strlen(mystr)-1)='s')){
printf("%ses\n",mystr);
}
else if(((strlen(mystr)-1)='h')){
printf("%ses", mystr);
}
else{
printf("%ss", mystr);
}
return 0;
}

Please use code tags (<< !! Posting Code? Read this First !! >>) when you post code in the future as well.

You have a few substantial errors/misunderstandings to clear up:
1. = is for assignment, == is for comparison
2. strlen(mystr)-1 doesn't give you the last character, it simply gives you the index of the last character. The last character is mystr[strlen(mystr)-1], which you've determined already.

Some general notes:
What is the purpose of tmp and a? Do you ever use them or can you get rid of them?
I suggest storing the length of mystr in a convenience variable, say "len". This will make your code more readable and more efficient (calling strlen is not free, it has to check every byte of the string every time).

Also, I strongly suggest you try the following when you get around to testing your program. I think you will find a logical error your "ends in an h" check:
bath->baths
watch->watches
bush->bushes