Thread: Getchar

Okay, so the word search didn't go over well. Fine.

I was hoping someone could identify what the problem is here: I can't get out of the while loop, even when I simply press enter on the command line (which is the new character, it should take me out of the loop). Any ideas?

Code:

#include <stdio.h>
#include <stdlib.h>


int main()

{
    char *string=(char*)malloc(sizeof(char)*100);
    char x=getchar();
  while(x!='\n')
  {
  *string=x;
  string=string+1;
  char x=getchar();
  }
  *string='\0';
  printf("%s",string);
}

Right, I sometimes forget about the return value when I'm experimenting with simple code like this.

I found some errors, I declared x twice for some reason. I modified the code:

Code:

#include <stdio.h>
#include <stdlib.h>


int main(void)

{
    char *string=(char*)malloc(sizeof(char)*100);
    char x;
    x=getchar();
  while(x!='\n')
  {
  *string=x;
  string=string+1;
  x=getchar();
  }
  *string='\0';
  printf("%s",string);
  return 0;
}

Now the problem is, at the end of the first getchar() the program just returns 0 regardless of which character I enter.

I'm not sure what you mean by returning 0, but I assume you mean that you aren't seeing what you typed as output to the terminal.

In this case, you may want to look at what you are doing to your string char pointer.

Ah so stupid, I added another string point to point to the original address of the string.

Problem solved, thanks.

You aren't stupid, people get tripped on that all the time.

don't change your string pointer.

this: string=string+1;
you loose the beginning of your string.

Try this instead: string[i] = getchar();
(you would need an i variable that gets incremented in each loop)

And in C you should never cast the return value of malloc.

so well, one more question extra added by me {
printf("What does getchar() stands for // represents of what? How to use it? My lecturer didnt teach this to me and i saw a lot of ppl using it and thats where the lecturer didnt even mention! ");

Originally Posted by l2krence

so well, one more question extra added by me {
printf("What does getchar() stands for // represents of what? How to use it? My lecturer didnt teach this to me and i saw a lot of ppl using it and thats where the lecturer didnt even mention! ");

Did you try looking up getchar() in your C library documentation?

// signals a short (one line) comment.