need help why code coredump(s)

[pfu]

Hi folks,

Im' a C newbie and I am working on some sample code. (please see below)

#include <stdio.h>
main()
{       

        int     mymood;
        char    type;

    printf("happy or sad [h/s]: ");
        scanf(" %c", type); 
        printf("type = %c\n", type);    
        mymood = type == 'h'; 
        if (mymood)
                printf("My mood is happy\n");
        else 
                printf("My mood is sad\n");

        getchar();

}

it compiles pretty well but when i try to run it and pick either 'h' or 's' it coredumps.. and I can't get it to work. =/

any help would be awesomely appreciated.
thanks,
pfu

[carrotcake1029]

You need to change this line

scanf(" %c", type);

to this

scanf(" %c", &type);

scanf is looking for the address of the char, not the char itself.

Also try and use code tags in the future

[Salem]

Since you mention segfaults, does that mean you're using gcc and Linux?

If so, use lots of compile flags to help you spot many dumb mistakes before you run the code.

Eg.
gcc -W -Wall -ansi -pedantic -O2 prog.c
would have warned you about the missing & in the scanf call.

[pfu]

To all that have replied ..

many thanks for the tips and response to my wimpy code.. that '&' did the fix.

I really appreciate this awesome forum, now that im starting with C..

thanks,
-pfu