Thread: Help with my code, Please!

of course it doesn't, your use of a and b is completely insane

are you sure "fscanf" can read " " (space I mean) from text file??

as I remember, you can use "strtok"..
get line per line and save it at temp variable..
and then,
temp = "abc c1 195" right now.. (for the first looping)
you must use strtok to seperate one by one and save to each variable..

and one more.. about "only loop for once".. while you are reading txt..
use "EOF" at looping..

while(!EOF(*pointer)){
bla bla bla

}

Originally Posted by Kinshara

are you sure "fscanf" can read " " (space I mean) from text file??

as I remember, you can use "strtok"..
get line per line and save it at temp variable..
and then,
temp = "abc c1 195" right now.. (for the first looping)
you must use strtok to seperate one by one and save to each variable..

and one more.. about "only loop for once".. while you are reading txt..
use "EOF" at looping..

Ehh, I think you also need to read the FAQ.

Don't use EOF to control a loop reading from a stream until EOF.

Do you really need to do it in C?(is it assignment?)
You could just simply use awk or perl...

Is your abc abc always going to appear consetively? If not you need to store them.

Originally Posted by Bayint Naung

That shouldn't be hard to translate to C. Isn't it?

It is not that easy because a naive implementation might result in worse performance than the Python version.

billMD, must you use C for this? I might suggest C++ due to certain facilities available in the C++ standard library, otherwise you will have to either implement them yourself in C, or use a non-standard C library.

In particular, it seems that you want to map strings to integers such that multiple instances of the string in the input will have their corresponding integer values added together. The thing is, you apparently have a pretty large amount of input, so searching an array may be not be a good idea unless it is sorted, but keeping the array sorted would make insertions expensive. Consequently, you might use a balanced binary tree or hash table to implement the mapping.

Did someone mention "speed"?

BillMD, Your Python program can be sped up by 10X, imo. I need to tinker with it, just a bit to test it and optimize it. We have an excellent record of beating the pants off any Python program's run-time.

What I'd like to get is a text file that you run in 30 seconds or so, in Python. If you will upload it to a file transfer web site like Swoopshare (free), and post up the URL to the file, (or attach it to your posted reply here, using the "manage attachments" button - there is a limit of 488 KB). I can get some tests underway.

Is this on a PC with a Windows or a Linux operating system? What was the cpu of the Python system the run-time was tested on?

There may be rumors that I'm a bit competitive with these kinds of things - don't believe a word of it. Not a word. Bill, not a damn word!! Send the file, Bill!

P.S. Would this same data file be processed just once, or is it a job, where the same data is having text lines added to it, and the same file then being re-processed regularly?

It took me a while to figure out what you're doing. I assume you don't expect a similar label somewhere down the list, so therefore we can just initialize the total once the label changes.

Code:

int main(int argc, char *argv[])
{
	FILE *fin = fopen(argv[1],"r");
	FILE *fout = fopen(argv[2],"w");
	char t[15], t_d[15], c_d[16];
	int tag, tag_d;

	if (NULL == fin || NULL == fout) {
		printf("Failure to open in or out files.\n");
		return 0;
		}
		
	t[0] = '\0'; /* initialize to empty string */

	while (fscanf(fin, "%s %s %d", t_d, c_d, &tag_d)==3) {
		if (strcmp(t, t_d)) {
			if (t[0])
				fprintf(fout, "%s %s %d\n", t, c_d, tag);
			tag = 0;
			}
		tag += tag_d;
		strcpy(t, t_d);
		}
	fprintf(fout, "%s %s %d\n", t, c_d, tag);

	fclose(fin);
	fclose(fout);

return 0;
}

I realize that doing homework is against board policy, but the OP had most of it alright. Just needed a bit of clean-up and simplification.
And a real compile & run test to verify everything is OK.