Thread: Extra characters with

When I use strncat, I get strange characters appended to my string, although the string buffer is only 8 bytes in size which is verified and its told to only copy 8 characters (which I've even tried hardcoding). Where are they coming from?

Code:

RecvMsg(buf, client, sizeof(buf)); //Recieve our packet
char p[((uint8(buf[0])<<8)|uint8(buf[1]))]; //Allocate just enough to hold the playername
memset(p, 0, sizeof(p));
std::string playerName = strncpy(p, buf + 2, sizeof(p));

Then std::cout << "Playername: " << p << std::endl;
or std::cout << "Playername:" << playerName << std::endl;
or printf(p);
or printf(playerName.c_str());

all result in:

MasterCQ��t�O��t�

Did you forget to include the end of string char: '\0'?

Does your string have a newline char: '\n' just before the end of it?

Couldn't you accomplish the same thing with this code and skip the intermediary buffer and temporaries?

Code:

RecvMsg(buf, client, sizeof(buf)); //Recieve our packet
std::string playerName(buf + 2, ((uint8(buf[0])<<8)|uint8(buf[1])));

Untested, but just a thought.