Thread: help with simple functions

Does anyone see anything wrong with these simple functions?

Basically, the "get_field" gets a word from the file of unknown length and "add_char" will add the character to the string.

The problem lies somewhere in the "add_char" function because the memory is never realloc'd. I don't get any error messages--the word is just blank when printed. :-(

Code:

char *add_char(char *string,char character)
{
    char *tmp=realloc(string,sizeof(string)+sizeof(char));
    if(tmp!=NULL)
    {
        string=tmp;
    }
    string[sizeof(string)/sizeof(char)]=character;
    return string;
}

char *get_field(FILE *inputfile)
{
    char character;
    char *field;
    
    field=(char*)malloc(sizeof(char)*2);
    
    do
    {
        character=getc(inputfile);
        field=add_char(field,character);
    }
    while(character!='\0');
    
    field[sizeof(field)]='\0';
    
    return field;
}

Read this,http://c-faq.com/malloc/reallocnull.html
What are you trying to do?
It looks like you are making things complicated

Hahaha! I tend to do that.

Essentially, I want to read in a word of unknown length from a file.

It must be in C.

realloc may readjust the data in the memory as it resizes the segment. so if you realloc a string chances are the returned pointer may not contain a valid string..