Hi,
I am trying to add some value to the low byte of a number according to my logic this should work.
Current code should work assuming number is unsigned.
it doesn't work with many numbers,even though its simply should 100 %.Code:nValue = nValue | ( (nValue & 0xFF) | nAdd);
Try
Code:nValue = (nValue & 0xFFFFFF00) | ((nValue | nAdd) & 0xFF);
It doesn't work because the logic is flawed. Try working out the result in your mind when both nValue and nAdd are 1. The result should be 0b10 (decimal 2), but your code produces just 0b1 (decimal 1). You also don't take 'carry' into consideration at all - when corresponding bits are both 1, the sum of the bits should be 0 and a carry of 1 for the next higher bit should be produced. (Hint: Look into how half-adder & full-adder are implemented; also there are Google hits containing the solution.)Originally Posted by Mr.Generic
Last edited by qwertylurker; 08-17-2010 at 05:45 AM.
thanks both for your answer.
I didn't google because I didn't know what exactly to google for :P,but anyway I get why it doesn't work now,also thanks for your link.
Well wait, are you actually trying to ADD to the lower byte or replace it? The code from the original post pointed towards replacing it, I thought that's what you wanted to do.
I wanted to add lower byte I forgot about also carry operation that qwer states.
