Concatenate ascii threads - segmentation fault

[CppDev]

I have a hexadecimal string that I want to convert to a regular string (to send as a tcp message).

I took every two digits (say 61), converted them to a long int (say my_int = 6*16 +1 = 97) and got the corresponding ascii character (in this case "a")

//e.g. 
	char* string1 = (char*) 97;

string1 points to the character string "a" whose ascii value is 97.

char* string1 = (char*) my_int;
char* string2 = (char*) my_int2;

char* string2 = malloc(1024);

Now I want to concatinate string1 and string2, and store them in string2.
But I get a segmentation fault, whether I use strcpy(), strcat(), or even a function that I write.

(PS: I am writing in C and I need the final string to be of type char*)

[sean]

You're declaring string2 twice and overwriting it's initial value. If there isn't a null character soon enough in the new allocated memory, you'll easily end up running out of bounds - hence the segfault. But even if there was - you're not concatenating what you think you're concatenating.

[Salem]

> string1 points to the character string "a" whose ascii value is 97.
No, it points to address 97, which could be anything - even a segfault.

Start with something like this

printf("Some chars = %c %c %c\n", 'a', 97, 0x61 );
int foo = 97;
char buff[1024];
sprintf( buff, "Int=%d, char=%c\n", foo, foo );
printf( "Buff=%s", buff );