Thread: Read, Write on files.. counting lines.. stuff like that

girone.c:10: warning: comparison between pointer and integer

"\n": using double quotes creates a const char pointer to that string in memory. You want to use single quotes to specify a single char: '\n'.

Most of the other errors:
You need to declare your struct first (using typedef, if desired) and then create an instance later when you want to use one. The compiler is complaining because void caricastruct() uses your struct before you define it in main().

Thanks Epy, really quick!
Well, it gives me a pair of error yet.. past new errors:

Code:

girone.c:50: error: conflicting types for 'caricastruct'
girone.c:27: error: previous implicit declaration of 'caricastruct' was here
girone.c:54: error: conficting types for 'scrivistruct'
girone.c:28: error: previous implicit declaration of 'scrivistruct' was here

i just don't know why!

fixed that '\n' and used the typedef, past new code here:

Code:

#include <stdio.h>

#include <stdlib.h>

typedef struct {

	char nome[10];

	int vinte;

	int perse;

	int pareggiate;

	int fatti;

	int subiti;

	} classifica;

int main(void){

	

	classifica class;

	classifica *pclass;

	FILE *read;

	FILE *write;

	int i,nsquadre;	

	

	read=fopen("es22.dat", "r");

	write=fopen("classifica.dat","wb");

	nsquadre=contasquadre(read);

	pclass=&class;

		

	for(i=0; i<nsquadre; i++){

		caricastruct(pclass, read);

		scrivistruct(pclass, write);

	}



	fclose(read);

	fclose(write);

	

return 0;

}



int contasquadre(FILE *read){

	char linee;

	int n;

	

	do { 	

		linee = getc(read);

		if(linee=='\n') n++;

	}

	while (linee != EOF);



return n;

}



void caricastruct(classifica *pclass, FILE *read){

	fscanf(read, "%s %d %d %d %d %d", (*pclass).nome,(*pclass).vinte,(*pclass).perse,(*pclass).pareggiate,(*pclass).fatti,(*pclass).subiti);

}



void scrivistruct(classifica *pclass, FILE *write){

	int partite,punti,differenzareti;

	partite=(*pclass).vinte + (*pclass).perse + (*pclass).pareggiate;

	punti=3*((*pclass).vinte)+(*pclass).pareggiate;

	differenzareti=(*pclass).fatti - (*pclass).subiti;

	

	fprintf(write,"%s %d %d %d", (*pclass).nome, partite, punti, differenzareti);

}

if anyone can help...

Line 50? where???
Put function prototypes before calling functions.

You mean like this:

Code:

...
int contasquadre(FILE*);
int caricastruct(classifica, FILE*);
int scrivistruct(classifica, FILE*);
...

?

It doesn't change a bit.. .___.

Your prototypes for caricastruct and scrivistruct do not match the definitions. What is the type of the first parameter in the definition?

Yeah, I know that..

the first type is classifica!

Code:

[..]
typedef struct {
	char nome[10];
	int vinte;
	int perse;
	int pareggiate;
	int fatti;
	int subiti;
	} classifica;
[...]

...this is classifica.
then, in main function i've declareted

classifica class;
classifica *pclass;

and that's what i try to fit in caricastruct and scrivistruct..
i know i'm newbie and this is an newbie's error.. i just can't figure out what could be..

The type of the first parameter of caricastruct and scrivistruct in their definitions is classifica *. Your declarations have classifica not classifica *.

you're right,
but the error still remain .-. just tried. .__.

So you have put the following lines in front of the main function:

Code:

int contasquadre(FILE*);
int caricastruct(classifica *, FILE*);
int scrivistruct(classifica *, FILE*);

and you are still getting the identical errors as shown in the last message where you showed errors?

If you are still having problems, please repost your current code and the current errors.

Here you go!

Code:

#include <stdio.h>

#include <stdlib.h>



typedef struct {

	char nome[10];

	int vinte;

	int perse;

	int pareggiate;

	int fatti;

	int subiti;

	} classifica;



int contasquadre(FILE*);

int caricastruct(classifica *, FILE*);

int scrivistruct(classifica *, FILE*);



int main(void){

	

	classifica class;

	classifica *pclass;

	FILE *read;

	FILE *write;

	int i,nsquadre;	

	

	read=fopen("es22.dat", "r");

	write=fopen("classifica.dat","wb");

	nsquadre=contasquadre(read);

	pclass=&class;

		

	for(i=0; i<nsquadre; i++){

		caricastruct(pclass, read);

		scrivistruct(pclass, write);

	}



	fclose(read);

	fclose(write);

	

return 0;

}



int contasquadre(FILE *read){

	char linee;

	int n;

	

	do { 	

		linee = getc(read);

		if(linee=='\n') n++;

	}

	while (linee != EOF);



return n;

}



void caricastruct(classifica * pclass, FILE * read){

	fscanf(read, "%s %d %d %d %d %d", (*pclass).nome,(*pclass).vinte,(*pclass).perse,(*pclass).pareggiate,(*pclass).fatti,(*pclass).subiti);

}



void scrivistruct(classifica *pclass, FILE * write){

	int partite,punti,differenzareti;

	partite=(*pclass).vinte + (*pclass).perse + (*pclass).pareggiate;

	punti=3*((*pclass).vinte)+(*pclass).pareggiate;

	differenzareti=(*pclass).fatti - (*pclass).subiti;

	

	fprintf(write,"%s %d %d %d", (*pclass).nome, partite, punti, differenzareti);

}

And now the errors:

Code:

girone.c:54: error: conflicting types for 'caricastruct'
girone.c:14: error: previous declaration of 'caricastruct' was here
girone.c:54: error: conflicting types for 'caricastruct'
girone.c:14: error: previous declaration of 'caricastruct' was here
girone.c:58: error: conflicting types for 'scrivistruct'
girone.c:15: error: previous declaration of 'scrivistruct' was here
girone.c:58: error: conflicting types for 'scrivistruct'
girone.c:15: error: previous declaration of 'scrivistruct' was here

Yeah, you're right. stupid me!
edited, i can compile now, but surely i've mistaken something else! it creates classifica.dat as he should, but it writes there some nonsenses..


aƒÎahÍ" 1631930957 6844463 -1629649438
aƒÎahÍ" 1631930957 6844463 -1629649438
aƒÎahÍ" 1631930957 6844463 -1629649438

is it windows fault?

Some funny four-eyed prof told me "you can be sure that when you allocate a struct, it is initialised all 0 by itself!"

gotcha, check the error, it were not so difficult to understand, i will try.