Thread: what's wrong with this piece of code?

below code can be compiled but can not run, what's wrong with it?

Code:

#include <stdio.h>
void getmemory(char ** pchar) {
	pchar = (char **)malloc(100);
}
int main(int argc, char *argv[]) {
	char *pstr = NULL;
	getmemory(&pstr);
	strcpy(pstr, "hello world");
	printf(pstr);
        return 0;
}

Code:

	pchar = (char **)malloc(100);
            // What you mean is 

             *pchar = malloc( 100 );

It's better to use printf("%s",pstr).

yes , i think so ,
thanks , it's okay now.