Help with completing this code

[Eskimoe]

Hi, I'm new to programming.. started a basic evening course and currently working on strutures.

The examples the course gave us are incomplete so I'm not sure why the following code isn't working..

so wondering if someone can check this out.

I think basically I've written the string of arrays (I think that is the correct term) wrong in the address function. When I run it in Visual Studios Express 2008 I get an exception error message pop up rather than a failed message in debug. the code is as follows.. thanks for reading

void get_address ( struct FRIEND add[], int num )
{
	int line = 0;

	for ( line = 0; line < num; line++ )
	{
		printf ( "Enter your friends Address\n:" );

		printf ( "Enter line %d of address:", line + 1 );
		gets ( &add[num].person.address );
	}
}

Full code

#include <stdlib.h>
#include <stdio.h>
#include <string.h>


struct CONTACT
{
	char name[30];
	char address[4][30];
	char postcode [8]; 
};


struct DOB
{
	int day;
	int month;
	int year;
};

struct FRIEND
{
	struct CONTACT person;
	struct DOB date_birth;
};

void get_mate ( struct FRIEND *mate);
void get_address ( struct FRIEND add[], int num );
void get_birth ( struct FRIEND *mate );
void main()
{
	struct FRIEND mate;
	struct FRIEND add[4];

	get_mate ( &mate );
	get_address ( add, 4 );
	get_birth ( &mate );


}
void get_mate ( struct FRIEND *mate)
{
	printf ( "Enter your friends details:" );

	printf ( "\nEnter Name: " );
	gets ( &mate->person.name );
}
void get_address ( struct FRIEND add[], int num )
{
	int line = 0;

	for ( line = 0; line < num; line++ )
	{
		printf ( "Enter your friends Address\n:" );

		printf ( "Enter line %d of address:", line + 1 );
		gets ( &add[num].person.address );
	}
}
void get_birth ( struct FRIEND *mate )
{
	printf ( "\nEnter Date of Birth:" );
	
	printf ( "Year: " );
	scanf ( "%d", &mate->date_birth.year );
	fflush ( stdin );

	printf ( "Month (1-12): " );
	scanf ( "%d", &mate->date_birth.month );
	fflush ( stdin );

	printf ( "Day: " );
	scanf ( "%d", &mate->date_birth.day );
	fflush ( stdin );
}

[claudiu]

A few things:

1) NEVER use fflush(stdin). If your instructor taught you that he is an idiot.

2) NEVER use gets(). If your instructor taught you that, again, he is an idiot.

Here is why fflush(stdin) is bad: Cprogramming.com FAQ > Why fflush(stdin) is wrong

Here is why gets() is bad: Cprogramming.com FAQ > Why gets() is bad / Buffer Overflows

3) main should be of type int main(void) and should have "return 0;" at the end of it. Again, should I mention the instructor?

Here is why: Cprogramming.com FAQ > main() / void main() / int main() / int main(void) / int main(int argc, char *argv[])

4) Now for the actual loop. Inside the loop you are iterating around "line" but you are never using that as an index when you are reading the respective friend. Instead you are using the loop's limit "num" as an index. Replace:
add[num].person.address with add[line].person.address

[xniinja]

I ran this in my own compiler and you need to let the person enter the friends details.