Thread: Returning strings help

the code below compiles but when I try to run it, it crashes and says "segmentation fault", please help.

insert

Code:

#include <string.h>
#include <time.h>
#include <stdio.h>


char* get_time();

main () {

	char *c;
	
	c = get_time();
	printf("%s\n", c);

       return 0;
}

char* get_time() {

  char *buffer;
  time_t curtime;
  struct tm *loctime;
 
  curtime = time (NULL);

  loctime = localtime (&curtime);
 
  strftime (buffer, 30, " %d/%m/%Y %I:%M:%S\n", loctime);
	printf("%s\n", buffer);
return buffer;
}

You're returning and then trying to print out, the contents of a variable that has gone out of scope (died).

Golden Rule: Don't return the address of Zombies!

(because C points to buffer, and buffer is dead)

Ok, so how can I get round this problem? Im obviously trying to display the current time.
Cheers

Ok, Im really new to this, so can you give me some tips on how to solve my problem?
Cheers

You never allocated any space in buffer to hold the data strftime puts into it. EDIT: As stated by MK27, he beat me to it grrr...

IE you need to allocate some space in buffer first, then returning buffer will not be an issue, other then the fact that the caller needs to free() it at some point.

So should I define buffer as char[30] ?

Sorry guys but Im still not getting any success, Ive tried declaring buffer as a char[30] but main() just prints out garbage now.

Ok Ive tried using malloc() but I now get an error saying "invalid conversion from void* to char* "

You didn't include stdlib.h in your program (prototypes free() and malloc()).

No I have included that file

Then repost your new code.

insert

Code:

#include <string.h>
#include <time.h>
#include <stdio.h>
#include <stdlib.h>


char* get_time();

main (int argc, const char *arcv[]) {

	char *c;
	
	c = get_time();
	printf("%s\n", c);
        free(c);
       return 0;
}


char *get_time() {

  char *buffer = malloc(30);
  time_t curtime;
  struct tm *loctime;
 
  curtime = time (NULL);

  loctime = localtime (&curtime);
 
  strftime (buffer, 30, " %d/%m/%Y %I:%M:%S\n", loctime);

return buffer;
}

Im using the text editor gedit