String comparison.

[zigbigidorlu]

int compare_masterpw(const char* password)
{
	char pas;
	FILE* fp = fopen("conf/bypass.txt", "r");


	ShowInfo("Reading file conf/bypass.txt...\n");
	if (fp == NULL) {
		ShowError("Could not load password bypass file! (conf/bypass.txt)\n");
		return 0;
	}
	ShowInfo("Done reading conf/bypass.txt.\n");

	fgets(pas,100,fp);
	fclose(fp);

	ShowImportant(pas,"\n");
	ShowImportant(password,"\n");

	if(pas == password)
	{
		ShowImportant("Good\n");
		return 1;
	}
	else
	{
		ShowImportant("Bad\n");
		return 0;
	}
}

When I compile, I get these errors:

login.c:237: warning: implicit declaration of function âcompare_masterpwâ
login.c: In function âcompare_masterpwâ:
login.c:1530: warning: passing argument 1 of âfgetsâ makes pointer from integer without a cast
login.c:1533: warning: passing argument 1 of âShowImportantâ makes pointer from integer without a cast
login.c:1536: warning: comparison between pointer and integer
login.c:1530: warning: âpasâ is used uninitialized in this function

Any idea how I might fix this?

[hk_mp5kpdw]

char pas;

...

fgets(pas,100,fp);

...

if(pas == password)

First off, it looks like you're trying to read 100 characters into a buffer that's only got space for a single character. Your "pas" variable needs to be made into an array.

Second, you can't compare C-style strings (null terminated char arrays) using the equality operator ==. The above code will only end up comparing the addresses of the two arrays which are NEVER going to be equal. You need to use the strcmp function.