Thread: convert char array to integer number

Hello,

I am attempting to convert a number from an array of chars into a reconstructed number. For example if I have an array:

Code:

 char array[5] = {5,4,3,2,1};

How can I convert it into

Code:

 int converted = 54321;

So far I have

Code:

#include <stdio.h>

int main(int argc, char *argv[])
{
    int lc_count;
    int tmp;
    int array_mult = 1;
    int hours_array[5] = {0,1,2,3,4};   // value is 1234
    int i = 4;
    
    for(lc_count = 0; lc_count <= 5; lc_count++)
    {
                 tmp = hours_array[i] * array_mult;
                 array_mult *= 10;
                 --i;
                 tmp += tmp;
    }
    
    printf("count value is:   %d" ,tmp);               
    
    system("PAUSE");    
    return 0;
}

but the output of printf is -200000, could anyone advise on what I may be doing incorrectly here?

Thanks
Dave

since an array of chars is basically a string, why not try this...

Code:

#include <stdio.h>
#include <string.h>
#include <ctype.h>

int main (int argc, const char * argv[]) 
{
	int test = 0, intstr;
	char str[6];

	do {

		printf("insert string -> ");
		scanf("%s", str);

		for (i=0; i<strlen(str); i++)
			if (isalpha(str[i])) 
				test++;	
	} while (test != 0);
	intstr = atoi(str);

	return 0;
}

Don't forget to check for overflows. It's probably a good idea to validate the char array as well so you don't end up doing operations with negative numbers.

Code:

#include <stdio.h>
#include <stdlib.h>
#include <math.h>
#include <limits.h>

int main(void)
{
        int result = 0;
        const char arr[] = {5,4,3,2,1};
        const size_t num_elems = sizeof(arr) / sizeof(arr[0]);
        int mult = pow(10, num_elems - 1);
        size_t i;

        for (i = 0; i < num_elems; ++i)
        {
                if (result > INT_MAX - arr[i] * mult)
                {
                        fprintf(stderr, "%s\n", "Integer overflow");
                        return EXIT_FAILURE;
                }

                result += arr[i] * mult;
                mult /= 10;
        }

        printf("Result: %d\n", result);

        return EXIT_SUCCESS;
}

there were just 2 errors in the orig. code, 1st the already mentioned summing up in the tmp var, second the obo ( off by one :-) error in the for loop:

Code:

#include <stdio.h>

int main(int argc, char *argv[]) {

    int lc_count;
    int tmp=0;
    int array_mult = 1;
    int hours_array[5] = {0,1,2,3,4};   // value is 1234
    int i = 4;
    
    for(lc_count = 0; lc_count < 5; lc_count++) {
                 tmp = tmp + hours_array[i] * array_mult;
                 array_mult *= 10;
                 --i;
    }    
    printf("count value is:   %d \n" ,tmp);                   
    system("PAUSE");    
    return 0;
}

Thank you very much kermitaner, that was exactly what I was after - have yourself a fine Hannovarian beer !

To laserlight - thanks for pointing out those functions, I had not heard of those before.

--dave

and as always, there is another complication...

I have just realised that the array contains ASCII char values, which breaks this code, so I have tried this:

Code:

#include <stdio.h>

int main(int argc, char *argv[]) {

    int lc_count;
    int tmp=0;
    int array_mult = 1;
    char hours_array[5] = {'1','5','9','7','4'};   // value is 1234
    int i = 4;
    
    for(lc_count = 0; lc_count < 5; lc_count++)
    {                 
                 hours_array[i] -= 0x30;
                 --i;
                 printf("%d\n\n", hours_array[i]);
    }
    
    for(lc_count = 0; lc_count < 5; lc_count++) {
                 tmp = tmp + hours_array[i] * array_mult;
                 array_mult *= 10;
                 --i;
    }    
    printf("count value is:   %d \n" ,tmp);                   
    system("PAUSE");    
    return 0;
}

the result from this is:

Code:

55

57

53

49

-1

count value is:   -14111

which is baffling considering the last time I looked 0x30 - 0x4 was not 0x55....

--dave

Thanks Adak, that was indeed what I was trying to do.

Yes, I really should have removed that comment..

Would it be possible to ask why you set up the for loop like that and what tmp2 does, please?

--dave

Originally Posted by droseman

Thanks Adak, that was indeed what I was trying to do.

Yes, I really should have removed that comment..

Would it be possible to ask why you set up the for loop like that and what tmp2 does, please?

--dave

Sure! Go ahead and ask!


Just messing with ya!

That's just the standard way to walk through an array, decrimenting. Tmp2 is just a placeholder. We need that value before we can start the next line of code. I suppose you could do something with parentheses, but the simpler your code logic is, (generally), the better.

Cheers for that.

Is there any way this can get itself stuck in an infinite loop, since that is what has happened when I put it into my main (embedded) application.

--dave

Did you note that I changed the name of the array in my example?

(I dislike long array names).

Do you need to keep this char array as just char's and not add the end of string char to the end of it? Doing so would elevate it to a string, and then the standard string to number functions could be used.

Post up your code that shows the endless loop, and I'll see what's up with it.