Thread: loop problem

Hi all!

I don't know what's wrong with my code. The program behaves as if the if-memchr-line wouldn't exist. Perhaps there's a problem with passing the next struct (p) in the linked llist, while running the loop many times?

Thanks in advance for help!

Code:

	while(!feof(fp))
	{
		fgets(buf, 750, fp);
		if(memchr(buf, '~', 750))
		{
			if(head)
			{
				if(save==1)
				{
					Print(head);
				}
				Delete(head);
			}
			head = malloc(sizeof *head);
			p=malloc(sizeof(struct node));
			head->next=p;
			save=0;
		}
		Build_linked_list(p);
	}

After you fix the feof() problem, switch from memchr() to strchr(). The way you have it searches the entire 750 bytes of the array (I assume it's 750 bytes long) for a tilde; but unless you type a 750 character line, fgets() will store fewer than 750 bytes. There is almost no reason why, if you're reading a string, you wouldn't want to just search that string for a character. Otherwise you're searching garbage (or previously stored values) past the end of the newly-read string.

Thanks for the comments!

The big mistake in my code seemed to be that I tried to build the beginning of the linked list in the main function and the tail in another function. Now I understand that the entire linked list should be built in one function... Should this be the main function or can it be built it in other functions as well.

...so instead of writing:

Code:

Build_linked_list(p);

,,,I should write:

Code:

Build_linked_list(p, p->next);

...and the called function should begin like this:

Code:

struct node* Build_linked_list( struct p, struct p->next )

I hope I've understood it right...

Now I understand...
I've to pass the head and then wind up the linked list till the place where I wanna add something.

Thanks for the help!