reading a random grid from file into an array

[seandil666]

Hello,
basically trying to store characters in a grid from a file in to an array
i can compile this without any errors
but won't run
maybe a misconception?
any help would be great. thanks.

#include<stdio.h>
#include<stdlib.h>
#include<string.h>

int main()
{
 int i = 0,j=0;
 FILE *f;

 f = fopen("grid1.txt","r");

 char a[10][10];

 for(i=0;i<10;i++)  {
     for(j = 0; j < 10; j++)
     {
         fscanf(f,"%s", a[i][j]);
     }
 }


/*test output*/
 printf ("\n%s\n",a[0][0]);

}

sample input file

asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa

[BEN10]

Hello,
basically trying to store characters in a grid from a file in to an array
i can compile this without any errors
but won't run
maybe a misconception?
any help would be great. thanks.

#include<stdio.h>
#include<stdlib.h>
#include<string.h>

int main()
{
 int i = 0,j=0;
 FILE *f;

 f = fopen("grid1.txt","r");

 char a[10][10];

 for(i=0;i<10;i++)  {
     for(j = 0; j < 10; j++)
     {
         fscanf(f,"%s", a[i][j]);
     }
 }


/*test output*/
 printf ("\n%s\n",a[0][0]);

}

sample input file

asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa
asfgasfffa

a[i][j] is a char not a string. To read strings replace it with a[i] only.

[seandil666]

a[i][j] is a char not a string. To read strings replace it with a[i] only.

thanks for that...

now I have just seperated some code(searching) into a function, and doesnt work anymore (can compile, would run until the searching starts)
im sure the problem is in the function parameters
not sure why pointers are used, as yet - as a beginner

I have marked the places which are of pain..

any help would be great..

#include<stdio.h>
#include<stdlib.h>
#include<string.h>

int main()
{
 	int i=0,j=0;
 	FILE *f;

 	f = fopen("grid1.txt","r");

 	char a[50][50];

	int width, height;

    fscanf(f,"%d %d",&width,&height);

	fclose(f);
	f = fopen("grid1.txt","r");

	for(i=0;i<height+2;i++)  {
     	for(j = 0; j < width && fscanf(f,"%s",a[i])==0; j++)
    	{
         	fscanf(f,"%s",a[i]);
    	}
 	}

	for(i=2;i<height+2;i++)  {
     	for(j = 0; j < width ; j++)
    	{
         	printf("%c",a[i][j]);
    	}
    	printf("\n");
 	}
 	wordSearch("england", a, width, height);
}

wordSearch(char *word[], char *a[50][50], int width, int height)
{
	int i,j,x,d,l,b,c;
	x=strlen(*word);
	for(i=2;i<height+2;i++)  {
     	for(j = 0; j < width ; j++)
    	{
         	if(word[0]==a[i][j])
         	{
				c=c+1;
				if(width-j>x-1)
				{
					d=j+1;

					for(l=1;l<x;l++)
					{
						if(word[l]==a[i][d])
						{
								b=b+1;
								d=d+1;
								if(b==x-1)
								{
								    printf("horizontal match");
								    b=0;
								}
						}
					}
				}
			}
    	}

	}
	for(j = 0; j < width ; j++)  {
     	for(i=2;i<height+2;i++)
    	{
         	if(word[0]==a[i][j])
         	{
				c=c+1;
				if(height-i>x-1)
				{
					d=i+1;

					for(l=1;l<x;l++)
					{
						if(word[l]==a[d][j])
						{
								b=b+1;
								d=d+1;
								if(b==x-1)
								{
								    printf("match");
								    b=0;
								}
						}
					}
				}
			}
    	}
	}
}

[BEN10]

You're passing "england" which is 1D string literal, so you should have the function as

void wordSearch(char *word, char *a[50][50], int width, int height)
and then
strlen(word);

char *word: word is a pointer pointing to char *.
char *word[]: word is an array containing char *.

By the way when you're using char *word[], what do you think word[1] would be?

[seandil666]

You're passing "england" which is 1D string literal, so you should have the function as

void wordSearch(char *word, char *a[50][50], int width, int height)
and then
strlen(word);

char *word: word is a pointer pointing to char *.
char *word[]: word is an array containing char *.

By the way when you're using char *word[], what do you think word[1] would be?

i tried it. but I get errors now about 'pointer integer comparisons'?? :/
any ideas? how to go about this..
thanks

#include<stdio.h>
#include<stdlib.h>
#include<string.h>

int main()
{
 	int i=0,j=0;
 	FILE *f;

 	f = fopen("grid1.txt","r");

 	char a[50][50];

	int width, height;

    fscanf(f,"%d %d",&width,&height);

	fclose(f);
	f = fopen("grid1.txt","r");

	for(i=0;i<height+2;i++)  {
     	for(j = 0; j < width && fscanf(f,"%s",a[i])==0; j++)
    	{
         	fscanf(f,"%s",a[i]);
    	}
 	}

	for(i=2;i<height+2;i++)  {
     	for(j = 0; j < width ; j++)
    	{
         	printf("%c",a[i][j]);
    	}
    	printf("\n");
 	}
 	wordSearch("england", a, width, height);
}

wordSearch(char *word, char *a[50][50], int width, int height)
{
	int i,j,x,d,l,b,c;
	x=strlen(word);
	for(i=2;i<height+2;i++)  {
     	for(j = 0; j < width ; j++)
    	{
         	if(word[0]==a[i][j]) warning: comparison between pointer and integer
         	{
				c=c+1;
				if(width-j>x-1)
				{
					d=j+1;

					for(l=1;l<x;l++)
					{
						if(word[l]==a[i][d])
						{
								b=b+1;
								d=d+1;
								if(b==x-1)
								{
								    printf("horizontal match");
								    b=0;
								}
						}
					}
				}
			}
    	}

	}
	for(j = 0; j < width ; j++)  {
     	for(i=2;i<height+2;i++)
    	{
         	if(word[0]==a[i][j])
         	{
				c=c+1;
				if(height-i>x-1)
				{
					d=i+1;

					for(l=1;l<x;l++)
					{
						if(word[l]==a[d][j])
						{
								b=b+1;
								d=d+1;
								if(b==x-1)
								{
								    printf("match");
								    b=0;
								}
						}
					}
				}
			}
    	}
	}
}

[rogster001]

char word is only going to be a char mate, even if you name the variable 'word'

[BEN10]

Again you're doing the same mistake. Here:

void wordSearch(char *word, char *a[50], int width, int height)

Here is a piece of code which will help you in your case. This passes parameters like in yours:

#include <stdio.h>
#include<string.h>
void vish(char *word,char *s[])
{
	int i;
	for(i=0;i<3;i++)
	if(*word==*s[i]) //compares 'e' with each of the first alphabet of the strings
		printf("\nTRUE");// print TRUE 2 times
}
int main() {
	char *ch[]={"egg",
		"what",
		"empire"
	};
    vish("england",ch);
	return 0;
}

[seandil666]

char word is only going to be a char mate, even if you name the variable 'word'

having fun?
why cant you just correct my code!!

[rogster001]

that was a good hint i thought! i am not knocking you man, its just the other post asked you to check what you thought char would be...

[seandil666]

that was a good hint i thought! i am not knocking you man, its just the other post asked you to check what you thought char would be...

its a good hint alright- except its alll a big riddle for me atm.
thx for the help anyway