Thread: Program crashes any ideas

I have problem when i tiping numer larger then 4. Program crashes and I don't know what is the problem. Program do smth like:
1

1 1
1 1

1 1 1
1 1 1
1 1 1

while matrix will be lenght x lenght size.

here is code:

Code:

#include <stdio.h>
#include <conio.h>
#include <stdlib.h>
#include <math.h>

//create piramide
void pyramid( int length)
{
	int j = 1, x=1, y=1, i, k=length, l=1, a[x][y];
    while ( k > 0 ){
          for ( x = 0; x < l; x++)
              for ( y = 0; y <l; y++)
              a[x][y]=rand()%200;
              for ( y = 0; y <l; y++){
                  for ( x = 0; x <l; x++)
                  printf ( "%d ", a[x][y]);
                  printf (" \n");
                  }
          k--;
          l++;
          x=1;
          y=1;
          printf (" \n");
          }
}


//main
int main( )
{
	int length;

	printf( "write piramide lenght:" );
	scanf( "%d", &length );
    pyramid (length);
  	getch( );
	return 0;
}

looking at the output you are providing in your query i am wondering how can u get the answer by the code which you wrote

And i don't think so that the program will crash it will print the junk value not the expected one

Originally Posted by anon

Nice indentation

Anyway, your array has room only for one number (a[0][0]) and you are trying to store more values in it.

Also nice use of l for variable name: looping from 0 to 1 would be OK, but not to l if it is more than 1.

so what you offer to me?

Originally Posted by anon

Nice indentation

Anyway, your array has room only for one number (a[0][0]) and you are trying to store more values in it.

Also nice use of l for variable name: looping from 0 to 1 would be OK, but not to l if it is more than 1.

I don't think that in the program:--

Code:

   a[x][y]=rand()%200;

in the above line the value of x and y will be any thing other than 1

he is correct at his logic in that point no overflow of value or out of index in case of 2 D int array called a