Thread: System calls (open, close, write)

The code below takes in program scores for an array of structures containing student information. It will correctly take in program scores for the first student in the array and write them to the file. For any other students, it will ask for the grades and accept them with no errors, but will not write them to the file.

Any ideas why?

Thanks

Code:

void addProg()
{
        int fd,s;
        struct rec *stdnt;

        fd = open("stdnt.dat", O_RDONLY, 0666);
        s = lseek(fd,0,L_XTND);
        int n = s/sizeof(struct rec);
        lseek(fd,0,L_SET);
        stdnt = malloc(s);
        read(fd,stdnt,s);

        int progNum;
        printf("Enter Program Number: ");
        scanf("%d", &progNum);
        int i;
        int tempProgScore;
        close(fd);

        fd = open("stdnt.dat", O_WRONLY, 0777);

        printf("%d",n);
        for(i=0;i<n;i++)
        {
                printf("Enter %s' score for program #%d:",stdnt[i].name, progNum);
                scanf("%d",&tempProgScore);
                stdnt[i].prog[progNum-1]=tempProgScore;
        }
        write(fd,stdnt,sizeof(struct rec));
        close(fd);
}

Originally Posted by bithub

Code:

write(fd,stdnt,sizeof(struct rec));

You are only writing one entry. Don't you want something more like:

Code:

write(fd,stdnt,sizeof(struct rec) * n);

I know the standard I/O alternative is

Code:

fwrite(stdnt, sizeof(struct rec), n, input);

which loops "n" times.

To try and reduplicate that, I tried putting my write statement in the above for loop but it didn't work.

I see what you mean though

Edit: "it didn't work" is the wrong way to put it. It worked, but it duplicated my first student to the second student

Originally Posted by bithub

No, it doesn't "loop" at all.

I bet that you did it wrong. If you simply did it the way I posted, that would be correct.

perhaps you could clear it up for me? i thought it simply wrote the stucture "n" number of times.

I edited my program to what you suggested and it did work, thank you!

Could you tell me why adding it into my for loop did not work?

Code:

for(i=0;i<n;i++)
        {
                printf("Enter %s' score for program #%d:",stdnt[i].name, progNum);
                scanf("%d",&tempProgScore);
                stdnt[i].prog[progNum-1]=tempProgScore;
                write(fd,stdnt,sizeof(struct rec));
        }

Originally Posted by bithub

It doesn't work the way you have it because you are just writing the same thing "n" times. To do it your way, modify the for loop to:

Code:

for(i=0;i<n;i++)
        {
                printf("Enter %s' score for program #%d:",stdnt[i].name, progNum);
                scanf("%d",&tempProgScore);
                stdnt[i].prog[progNum-1]=tempProgScore;
                write(fd,&stdnt[n],sizeof(struct rec));
        }

Well that provided some interesting results. A bunch of gibberish